Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If not logged in, you shouldn't get pinned to the homepage #16

Open
krancour opened this issue Mar 1, 2022 · 2 comments · May be fixed by #49
Open

If not logged in, you shouldn't get pinned to the homepage #16

krancour opened this issue Mar 1, 2022 · 2 comments · May be fixed by #49
Assignees
@DhairyaBahl
Labels
good first issue Good for newcomers
Milestone
v0.3.0

Comments

@krancour
Copy link
Contributor

krancour commented Mar 1, 2022

Currently, if you're not logged in, every page shows you an alert box and the home page content.

Let's keep the home page content on the home page only.

The home should not tell you "log in to see this content" (like it does not) because that's not actually trrue.

All other pages should say that if you're not logged in.
@krancour krancour added the good first issue Good for newcomers label Mar 1, 2022
@krancour krancour added this to the v0.2.0 milestone Mar 3, 2022
@DhairyaBahl
Copy link
Contributor

@krancour Kindly assign this to me.

@krancour
Copy link
Contributor Author

krancour commented Mar 8, 2022

Assigned

@DhairyaBahl DhairyaBahl linked a pull request Mar 15, 2022 that will close this issue
Open
@krancour krancour modified the milestones: v0.2.0, v0.3.0 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DhairyaBahl DhairyaBahl

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

If not logged in, login Alert is not pinned on homepage DhairyaBahl/brigade-dashboard
2 participants
@krancour @DhairyaBahl