Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: footer should not stick to the bottom #63

Open
krancour opened this issue Mar 22, 2022 · 4 comments · May be fixed by #70
Open

proposal: footer should not stick to the bottom #63

krancour opened this issue Mar 22, 2022 · 4 comments · May be fixed by #70
Assignees
@CIPHERTron
Labels
proposal Something to be discussed before moving forward

Comments

@krancour
Copy link
Contributor

In #59 @CIPHERTron wrote:

Also, the footer sticks to the bottom which might not be a great from UI/UX perspective according to me
@krancour krancour added the proposal Something to be discussed before moving forward label Mar 22, 2022
@krancour
Copy link
Contributor Author

I'm fine with that as long as the footer is still at the bottom of the viewport when a page doesn't have much content. i.e. I don't ever want the footer being in the middle of the page.

@krancour
Copy link
Contributor Author

@CIPHERTron lmk if you want to work on this.

@krancour krancour mentioned this issue Mar 22, 2022
Closed
@CIPHERTron
Copy link
Contributor

@CIPHERTron lmk if you want to work on this.

Yeah sure. I would love to work on this :D

@krancour
Copy link
Contributor Author

Thanks @CIPHERTron. All yours.

@CIPHERTron CIPHERTron linked a pull request Mar 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CIPHERTron CIPHERTron

Labels
proposal Something to be discussed before moving forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: footer should not fix to the bottom CIPHERTron/brigade-dashboard
2 participants
@krancour @CIPHERTron