You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The entire list is virtualized so I wouldn't really mind re-renders, however I'm using react-arborist for a directory data tree-view with drag and drop upload. During upload, I have a spinner that shows up next to the item signifying it's uploading state, however with progress updates (percentage uploaded) being part of the node data, the Row kept re-rendering and the spinner was stuttering. (Simple tailwind animate-spin)
I commented out line 29 of row-container.tsx
// useDataUpdates(); // Re-render when tree props or visability changes
this seems to have done the trick, but I'm not sure if I should expect any issues I might run into by removing it.
What was the idea between adding this? Visibility updates?
Thanks for sharing this component with the open source community! 👍
Edit: Clearly not the solution :( only some updates get propagated down now.
Edit2: Following the advice from react-window discussions I ralized my renderRow prop was being passed as an anonymous function, and thus re-rendered every time. Should be solved now :)
The text was updated successfully, but these errors were encountered:
The entire list is virtualized so I wouldn't really mind re-renders, however I'm using react-arborist for a directory data tree-view with drag and drop upload. During upload, I have a spinner that shows up next to the item signifying it's uploading state, however with progress updates (percentage uploaded) being part of the node data, the Row kept re-rendering and the spinner was stuttering. (Simple tailwind animate-spin)
I commented out line
29
ofrow-container.tsx
this seems to have done the trick, but I'm not sure if I should expect any issues I might run into by removing it.
What was the idea between adding this? Visibility updates?
Thanks for sharing this component with the open source community! 👍
Edit: Clearly not the solution :( only some updates get propagated down now.
Edit2: Following the advice from react-window discussions I ralized my
renderRow
prop was being passed as an anonymous function, and thus re-rendered every time. Should be solved now :)The text was updated successfully, but these errors were encountered: