From 10176f95bc2218ca4b09ba2f9ac7ea8a090c7d5f Mon Sep 17 00:00:00 2001
From: Wistpotion <99901732+Wistpotion@users.noreply.github.com>
Date: Sun, 9 Oct 2022 22:31:58 +0200
Subject: [PATCH] Improved input overflow efficiency (#77)

* Improved input

* Commented rewritten code
---
 gooey/internal/input.lua | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/gooey/internal/input.lua b/gooey/internal/input.lua
index 5043298..80a8d75 100644
--- a/gooey/internal/input.lua
+++ b/gooey/internal/input.lua
@@ -72,13 +72,32 @@ function INPUT.set_text(input, text)
 		local marked_text_width = get_text_width(input.node, marked_text)
 
 		-- prevent text from overflowing the input field
-		-- this will get increasingly expensive the longer the text
-		-- future improvement is to make a best guess and then either add or
-		-- remove characters depending on if the text is too short or long
 		local field_width = gui.get_size(input.node).x * gui.get_scale(input.node).x
-		while (text_width + marked_text_width) > field_width do
-			text = text:sub(2)
-			text_width = get_text_width(input.node, text)
+		if (text_width + marked_text_width) > field_width then
+			
+			-- guess how long the new text should be based on the previous text in the node
+			local field_text = gui.get_text(input.node)
+			local length = #field_text 
+
+			-- generate a best guess
+			local truncated = string.sub(text, -length, -1)
+			local truncated_width = get_text_width(input.node, truncated)
+
+			-- make sure the text is wider than field_width then shorten it to be within field_width
+			-- doing both makes sure that the text will be correctly sized no matter if the guess was too wide or too thin
+			while (truncated_width + marked_text_width) < field_width do
+				length = length + 1
+				truncated = string.sub(text, -length, -1)
+				truncated_width = get_text_width(input.node, truncated)
+			end
+			while (truncated_width + marked_text_width) > field_width do
+				length = length - 1
+				truncated = string.sub(text, -length, -1)
+				truncated_width = get_text_width(input.node, truncated)
+			end
+
+			-- finalize
+			text = truncated
 		end
 		
 		input.text_width = text_width