Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory and clean up missing steps from setup.py #1341

Closed
6 tasks done
Tracked by #1343
sjahl opened this issue Dec 5, 2023 · 1 comment
Closed
6 tasks done
Tracked by #1343

Inventory and clean up missing steps from setup.py #1341

sjahl opened this issue Dec 5, 2023 · 1 comment

Comments

@sjahl
Copy link
Contributor

sjahl commented Dec 5, 2023

During the v4 release, we uncovered some things that were previously handled by setup.py, but weren't captured in the new terraform configuration, such as registering the static IP for the gnomad browser. There's also some new things that weren't ever in setup.py

TODOs (still need to take a full inventory, but this is what comes to the top of my mind)

@sjahl
Copy link
Contributor Author

sjahl commented Dec 6, 2023

I combed through the setup.py code this afternoon, and didn't find anything obvious missing, except for the managed certificate, which is PRd now.

I found a few quality of life things, which have been added to the post-v4 epic.

@sjahl sjahl closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant