Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add educationRequirements in JobPosting #50

Closed
davdenic opened this issue May 4, 2020 · 3 comments
Closed

add educationRequirements in JobPosting #50

davdenic opened this issue May 4, 2020 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@davdenic
Copy link

davdenic commented May 4, 2020

Hello, is it possible to add
educationRequirements to
JobPosting ?
thanks

@brotkrueml brotkrueml self-assigned this May 4, 2020
@brotkrueml
Copy link
Owner

brotkrueml commented May 4, 2020

The extension provides the schema.org core vocabulary. educationRequirements is still pending (https://schema.org/educationRequirements) - that means, it can be renamed or abandoned - or taken over into the core vocabulary. This is due the fact, the schema extension doesn't want to break anything with a future schema.org update (approx. every month).

But you can add the property on your own to your site with a slot or event listener, have a look at:
https://docs.typo3.org/p/brotkrueml/schema/1.7/en-us/Developer/Events.html#register-additional-properties-for-a-type
So you have it under your control independently from the schema.org core updates.

When the property is available in the core vocabulary, the slot/event listener can be removed - but it doesn't harm if it still added.

Does that help you?

PS: I added a new feature issue to ease the registration in the future: #51

@brotkrueml brotkrueml added the question Further information is requested label May 4, 2020
@davdenic
Copy link
Author

davdenic commented May 4, 2020

Thanks, it works.
May i suggest a small change in the documentation?

in the example for version 9

$signalSlotDispatcher->connect(
   \Brotkrueml\Schema\Core\Model\AbstractType::class,
   'registerAdditionalTypeProperties',
   \Brotkrueml\Schema\EventListener\AdditionalPropertiesForPerson::class,
   '__invoke'
);

could be instead

$signalSlotDispatcher->connect(
   \Brotkrueml\Schema\Core\Model\AbstractType::class,
   'registerAdditionalTypeProperties',
   \YourVendor\YourExtension\Slot\AdditionalPropertiesForPerson::class,
   '__invoke'
);

@brotkrueml
Copy link
Owner

Yes you are right, if you like you can provide a pull request.

@brotkrueml brotkrueml pinned this issue May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants