Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement assertion error messages and more #46

Open
BridgeAR opened this issue May 6, 2019 · 3 comments
Open

Implement assertion error messages and more #46

BridgeAR opened this issue May 6, 2019 · 3 comments

Comments

@BridgeAR
Copy link
Member

BridgeAR commented May 6, 2019

As a follow-up of #44 it's still required to use util.inspect. That's currently not the case and a lot of message tests fail because of that.

@BridgeAR BridgeAR changed the title Implement assertion error messages Implement assertion error messages and more May 6, 2019
@BridgeAR
Copy link
Member Author

BridgeAR commented May 6, 2019

This issue is meant as general tracker for things that should be implemented after #44 landed.

As such we have to decide if we want to keep on supporting IE or not. I personally would drop the support in another semver-major. Otherwise it's difficult to keep up with changes and implement new features.

@BridgeAR
Copy link
Member Author

BridgeAR commented May 6, 2019

If someone would still want to use the IE they would have to transpile the code with babel accordingly and hope everything works well. I guess most features that someone in the IE would use would keep on working and it's mainly the tests that are difficult to keep up (like new language features are not required in the IE so code branches working specially for new types would not be taken etc).

@rvagg
Copy link

rvagg commented Jan 10, 2020

@BridgeAR are you maintaining this library these days? It could do with a new sync I think. throws, rejects and others seem to be outdated or missing (I've resorted to manual polyfills for both in different situations). Also yeah, error messages are pretty wonky when seen side-by-side with Node's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants