Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to browserify organisation #3

Open
2 of 3 tasks
dcousens opened this issue Apr 7, 2023 · 10 comments
Open
2 of 3 tasks

Move to browserify organisation #3

dcousens opened this issue Apr 7, 2023 · 10 comments
Assignees

Comments

@dcousens
Copy link
Member

dcousens commented Apr 7, 2023

Thanks @calvinmetcalf for helping start this process.
We probably have three parts to do:

  • Move the repositories
  • Update the repositories package.json information
  • Update the npm access to the browserify organisation (or relevant teams)

I am happy to move each of the packages from this organization to https://github.com/browserify and update their meta information in time. @ljharb could you move the package npm ownership/access to the relevant npm organisation/teams? 💛

The list of packages in https://github.com/crypto-browserify/ownership/blob/master/crypto-packages.json doesn't cover every package in this organisation. I'll move them across nonetheless and we can then add an issue to each repository to determine it's fate.

For example buffer-reverse, while useful, should be deprecated (Buffer has reverse now), but I'll still move it for now so we can do that in the right place.

@dcousens dcousens self-assigned this Apr 7, 2023
@ljharb
Copy link
Member

ljharb commented Apr 7, 2023

Yes, as soon as npm owner add ljharb has been run on each one, i'll get it set up in the browserify npm org properly.

(buffer-reverse should probably still be kept for browsers, and for older versions of node that lack it)

@dcousens
Copy link
Member Author

dcousens commented Apr 7, 2023

Step 1 complete 💛

@dcousens
Copy link
Member Author

dcousens commented Apr 7, 2023

@calvinmetcalf could you run this?
Some packages may fail, but that's OK, we'll double back when that happens

#!/bin/bash

while read -r package; do
	npm owner add ljharb "$package"
done << LIST
browserify-aes
browserify-des
browserify-rsa
browserify-scrypt
browserify-sign
cipher-base
create-ecdh
create-hash
create-hmac
crypto-browserify
diffie-hellman
evp_bytestokey
hash-base
md5.js
parse-asn1
pbkdf2
pseudorandombytes
public-encrypt
randombytes
randomfill
ripemd160
sha.js
timing-safe-equal
LIST

I have added @ljharb for these, as I still had ownership

buffer-reverse
buffer-xor

@dcousens
Copy link
Member Author

dcousens commented Apr 7, 2023

@calvinmetcalf you might end up needing to add a --otp flag, as in npm owner add ljharb "$package" --otp "123456" as npm owner errors in a non-interactive shell (or run each command manually)

@dcousens
Copy link
Member Author

dcousens commented Apr 7, 2023

Maybe there is merit to merging some of these packages, and the other node-like polyfills, into a monorepo (many packages, 1 repository) for easier maintenance too?
Could place the npm release process under a GitHub action too for increased auditing.

@ljharb
Copy link
Member

ljharb commented Apr 7, 2023

I'm much more skeptical about that personally - monorepos in my experience make things much harder to maintain in the long run. Let's get everything transferred, and update what needs updating, before regrouping on larger questions like that.

@dcousens
Copy link
Member Author

dcousens commented Apr 7, 2023

Sounds good.
I can understand that, except many of these packages are strictly dependent on each other and often need bumping and releasing in unison. As you say though, happy to regroup on that in time.

@calvinmetcalf
Copy link

calvinmetcalf commented Apr 8, 2023 via email

@calvinmetcalf
Copy link

ok all set

@ljharb
Copy link
Member

ljharb commented Apr 8, 2023

Thanks! I now have a "crypto" team in the browserify npm org with 24 packages on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants