Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Unpack Example Does Not Work #76

Open
ornj opened this issue Aug 4, 2015 · 2 comments
Open

Browser Unpack Example Does Not Work #76

ornj opened this issue Aug 4, 2015 · 2 comments

Comments

@ornj
Copy link

ornj commented Aug 4, 2015

$ browserify x.js y.js > bundle.js
$ browser-unpack < bundle.js | factor-bundle \
  x.js -o bundle/x.js \
  y.js -o bundle/y.js \
  > bundle/common.js

bundle/common.js is created. Neither bundle/x.js or bundle/y.js are created. It is my understanding that these bundles should be created with the modules that exist in the common bundle being omitted.

@spikebrehm
Copy link

does the bundle directory exist?

@ornj
Copy link
Author

ornj commented Aug 12, 2015

Yes it does. I just attempted this again with a clean directory by doing the following:

npm install browserify browser-unpack factor-bundle
mkdir bundle
cp node_modules/factor-bundle/example/files/* .
browserify x.js y.js > bundle.js
browser-unpack < bundle.js | factor-bundle x.js -o bundle/x.js y.js -o bundle/y.js > bundle/common.js
ls bundle
  common.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants