Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to ignore local dependencies in factorization process #78

Closed
PaGury opened this issue Nov 18, 2015 · 1 comment
Closed

Comments

@PaGury
Copy link

PaGury commented Nov 18, 2015

Hi,

It is possible to ignore some dependencies in the factorization process ?

I have 3 files

page1.js

var domready = require('domready');
var React = require('react/addons');
var localScript = require('./common/localScript');

domready(function() {
    // stuff
});

page2.js

var React = require('react/addons');
var localScript = require('./common/localScript');

domready(function() {
    // stuff
});

page3.js

var domready = require('domready');
var localScript2 = require('./common/localScript2');

domready(function() {
    // stuff
});

It would be great if we were able to configure factor-bundle to export domready and react/addons (node_modules dependencies) in a 'common-bundle.js' file. And able to ignore the 'localScript' for each files (maybe based on a regex, or a parameter 'ignoreLocalsDependencies').

Why ?

The export of common node_modules dependencies is pretty nice and usefull, but i do not want to export these locals dependencies in the common-bundle file. These locals would be used only in a few scripts and it's unnecessary to factorize. Unlike the node_modules dependencies.

@casr
Copy link

casr commented Sep 3, 2017

Might be worth looking at #16

@PaGury PaGury closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants