Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use facebook prepack instead of static-eval #47

Closed
dy opened this issue Oct 26, 2018 · 1 comment
Closed

Use facebook prepack instead of static-eval #47

dy opened this issue Oct 26, 2018 · 1 comment

Comments

@dy
Copy link

dy commented Oct 26, 2018

That would allow dynamic paths in require/readFileSync in brfs. Constant propagation is very demanded case

@goto-bus-stop
Copy link
Member

supporting more constant propagation would be nice but I'm not sure prepack does the kind of "local" propagation that static-module needs. We'd just need to inline the value of eg. a path passed to fs.readFileSync() but my understanding is that Prepack will partially evaluate the entire module and output a serialized form of that. Is that right?

It sounds like you could maybe run prepack first to inline stuff and then run static-module afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants