Merge pull request #611 from bruin-data/tests/integration-tests-connections-environement

Add Integration Tests for Connections and Environments

Author: DjamilaBaroudi

.github/workflows/tests.yml

@@ -85,47 +85,64 @@ jobs:
 
     - name: Run integration tests
       run: |
-        # Try to run integration tests, but don't fail the build if they fail
-        echo "Attempting to run integration tests..."
+        echo "Running integration tests..."
         
-        # Set Chrome-related environment variables
+        # Set Chrome-related environment variables and unique user data dir
         if [ "${{ runner.os }}" = "Linux" ]; then
           export CHROME_BIN=$(which google-chrome || which chromium-browser || which chromium)
+          export CHROME_USER_DATA_DIR="/tmp/chrome-user-data-$$"
           echo "Using Chrome at: $CHROME_BIN"
-          if xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm run selenium:run-tests; then
-            echo "✅ Integration tests passed successfully!"
-          else
-            echo "❌ Integration tests failed - likely due to ChromeDriver 404 download issue"
-            echo "This is a known issue with vscode-extension-tester ChromeDriver downloads"
-            echo "Unit tests and webview tests are still passing ✅"
-          fi
+          echo "Using user data dir: $CHROME_USER_DATA_DIR"
+          xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm run selenium:run-tests:connections
+          xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm run selenium:run-tests:ingestr
         elif [ "${{ runner.os }}" = "macOS" ]; then
           # Try different Chrome locations on macOS
           if [ -f "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" ]; then
             export CHROME_BIN="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
           elif [ -f "/Applications/Chromium.app/Contents/MacOS/Chromium" ]; then
             export CHROME_BIN="/Applications/Chromium.app/Contents/MacOS/Chromium"
           fi
+          export CHROME_USER_DATA_DIR="/tmp/chrome-user-data-$$"
           echo "Using Chrome at: $CHROME_BIN"
-          if npm run selenium:run-tests; then
-            echo "✅ Integration tests passed successfully!"
-          else
-            echo "❌ Integration tests failed - likely due to ChromeDriver 404 download issue"
-            echo "This is a known issue with vscode-extension-tester ChromeDriver downloads"
-            echo "Unit tests and webview tests are still passing ✅"
-          fi
+          echo "Using user data dir: $CHROME_USER_DATA_DIR"
+          npm run selenium:run-tests:connections
+          npm run selenium:run-tests:ingestr
         else
           # Windows - let extension tester handle Chrome detection
-          if npm run selenium:run-tests; then
-            echo "✅ Integration tests passed successfully!"
-          else
-            echo "❌ Integration tests failed - likely due to ChromeDriver 404 download issue"
-            echo "This is a known issue with vscode-extension-tester ChromeDriver downloads"
-            echo "Unit tests and webview tests are still passing ✅"
+          export CHROME_USER_DATA_DIR="C:\\temp\\chrome-user-data-$$"
+          npm run selenium:run-tests:connections
+          npm run selenium:run-tests:ingestr
+        fi
+      shell: bash
+
+    - name: Run webview integration tests
+      run: |
+        echo "Running webview integration tests..."
+        
+        # Set Chrome-related environment variables and unique user data dir
+        if [ "${{ runner.os }}" = "Linux" ]; then
+          export CHROME_BIN=$(which google-chrome || which chromium-browser || which chromium)
+          export CHROME_USER_DATA_DIR="/tmp/chrome-user-data-webview-$$"
+          echo "Using Chrome at: $CHROME_BIN"
+          echo "Using user data dir: $CHROME_USER_DATA_DIR"
+          xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm run selenium:run-tests:webview
+        elif [ "${{ runner.os }}" = "macOS" ]; then
+          # Try different Chrome locations on macOS
+          if [ -f "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" ]; then
+            export CHROME_BIN="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
+          elif [ -f "/Applications/Chromium.app/Contents/MacOS/Chromium" ]; then
+            export CHROME_BIN="/Applications/Chromium.app/Contents/MacOS/Chromium"
           fi
+          export CHROME_USER_DATA_DIR="/tmp/chrome-user-data-webview-$$"
+          echo "Using Chrome at: $CHROME_BIN"
+          echo "Using user data dir: $CHROME_USER_DATA_DIR"
+          npm run selenium:run-tests:webview
+        else
+          # Windows - let extension tester handle Chrome detection
+          export CHROME_USER_DATA_DIR="C:\\temp\\chrome-user-data-webview-$$"
+          npm run selenium:run-tests:webview
         fi
       shell: bash
-      continue-on-error: true
 
     - name: Store UI test logs
       uses: actions/upload-artifact@v4

.gitignore

@@ -7,4 +7,6 @@ node_modules
 .bruin.yml
 bruinPythonAsset.py
 example.txt
-integration-test-coverage-analysis.csv
+integration-test-coverage-analysis.csv
+generate-coverage-analysis.js
+real-coverage-calculator.js

package.json

@@ -538,9 +538,10 @@
     "build:webview": "cd webview-ui && npm run build-only && node scripts/copy-codicons.js",
     "vscode:prepublish": "npm run compile",
     "selenium:setup-tests": "extest setup-tests",
-    "selenium:run-tests": "node webview-ui/scripts/copy-test-assets.js && extest setup-and-run './out/ui-test/*.test.js' --code_version 1.103.0 --code_settings settings.json",
-    "selenium:run-tests-coordinated": "node webview-ui/scripts/copy-test-assets.js && extest setup-and-run './out/ui-test/{ingestr-asset-ui-integration,webview-tests}.test.js' --code_version 1.103.0 --code_settings settings.json",
+    "selenium:run-tests:connections": "node webview-ui/scripts/copy-test-assets.js && extest setup-and-run './out/ui-test/connections-integration.test.js' --code_version 1.103.0 --code_settings settings.json",
     "selenium:run-tests:ingestr": "node webview-ui/scripts/copy-test-assets.js && extest setup-and-run './out/ui-test/ingestr-asset-ui-integration.test.js' --code_version 1.103.0 --code_settings settings.json",
+    "selenium:run-tests:webview": "node webview-ui/scripts/copy-test-assets.js && extest setup-and-run './out/ui-test/webview-tests.test.js' --code_version 1.103.0 --code_settings settings.json",
+    "selenium:run-tests:all": "npm run selenium:run-tests:connections && npm run selenium:run-tests:ingestr && npm run selenium:run-tests:webview",
     "test": "node ./out/test/runTest.js",
     "test:webview": "cd webview-ui && npm run test",
     "compile": "tsc -p ./",

src/extension/extension.ts

@@ -661,21 +661,31 @@ export async function activate(context: ExtensionContext) {
   console.debug(`Bruin activated successfully in ${activationTime}ms`);
   console.timeEnd("Bruin Activation Total");
 
-  // Show walkthrough on first activation
+  // Show walkthrough on first activation (unless in test environment)
   if (isFirstActivation) {
     await context.globalState.update('bruin.hasActivated', true);
 
-    // Show walkthrough when extension is first installed
-    // Use a longer delay to ensure VS Code is fully loaded
-    setTimeout(() => {
-      vscode.commands.executeCommand('workbench.action.openWalkthrough', 'bruin.bruin-getting-started', true);
-    }, 3000);
+    // Check if we're in a test environment by looking for test-specific settings
+    const workbenchConfig = workspace.getConfiguration("workbench");
+    const walkthroughsDisabled = workbenchConfig.get<boolean>("welcomePage.walkthroughs.openOnInstall") === false;
+    const startupEditorNone = workbenchConfig.get<string>("startupEditor") === "none";
+    const isTestEnvironment = walkthroughsDisabled || startupEditorNone || process.env.NODE_ENV === 'test';
 
-    // Also show immediately if welcome tab is active
-    if (vscode.window.tabGroups.activeTabGroup.activeTab?.label === 'Welcome') {
+    if (!isTestEnvironment) {
+      // Show walkthrough when extension is first installed
+      // Use a longer delay to ensure VS Code is fully loaded
       setTimeout(() => {
         vscode.commands.executeCommand('workbench.action.openWalkthrough', 'bruin.bruin-getting-started', true);
-      }, 500);
+      }, 3000);
+      
+      // Also show immediately if welcome tab is active
+      if (vscode.window.tabGroups.activeTabGroup.activeTab?.label === 'Welcome') {
+        setTimeout(() => {
+          vscode.commands.executeCommand('workbench.action.openWalkthrough', 'bruin.bruin-getting-started', true);
+        }, 500);
+      }
+    } else {
+      console.log('Skipping walkthrough in test environment');
     }
   }