Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pinned url dependencies #188

Open
chmeliik opened this issue Aug 14, 2024 · 1 comment
Open

Add support for pinned url dependencies #188

chmeliik opened this issue Aug 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@chmeliik
Copy link

chmeliik commented Aug 14, 2024

pybuild-deps requires that all the input requirements be "pinned," which currently means:

  • name == version
  • name @ vcs_url@branch/tag/commit

It is not possible to use direct url (non-vcs) dependencies.

Arguably, url dependencies are superior to vcs dependencies because they are compatible with hash checking.

A direct url dependency could be considered pinned if it declares a hash.

@chmeliik
Copy link
Author

Like #186 and #187, this also comes from investigating the suitability of this tool for use with cachi2.

More details about cachi2's take on hash checking in https://github.com/containerbuildsystem/cachi2/blob/main/docs/pip.md#hashes

@bruno-fs bruno-fs added the enhancement New feature or request label Aug 15, 2024
bruno-fs added a commit that referenced this issue Sep 3, 2024
Modified pybuild-deps internals to rely more on pip internals, which
gave us both support for url dependencies and zip archived packages
for "free". This should fix (or at least cover most of) issues #188
and #187.

We will need to watch closely when pip releases new versions in order
fix breaking changes in its internal APIs.
bruno-fs added a commit that referenced this issue Sep 3, 2024
Modified pybuild-deps internals to rely more on pip internals, which
gave us both support for url dependencies and zip archived packages
for "free". This should fix (or at least cover most of) issues #188
and #187.

We will need to watch closely when pip releases new versions in order
fix breaking changes in its internal APIs.
bruno-fs added a commit that referenced this issue Sep 3, 2024
Modified pybuild-deps internals to rely more on pip internals, which
gave us both support for url dependencies and zip archived packages
for "free". This should fix (or at least cover most of) issues #188
and #187.

We will need to watch closely when pip releases new versions in order
fix breaking changes in its internal APIs.
bruno-fs added a commit that referenced this issue Sep 7, 2024
Modified pybuild-deps internals to rely more on pip internals, which
gave us both support for url dependencies and zip archived packages
for "free". This should fix (or at least cover most of) issues #188
and #187.

We will need to watch closely when pip releases new versions in order
fix breaking changes in its internal APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants