-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small suggestions #3
Comments
The audio is made using the text-to-speech web API, here is the code that uses text-to-speech. The reason why the text-to-speech web API has errors with pronouncing "開く" as "ひらく" instead of "あく" is because the code is passing in the kanji instead of the hiragana. If we pass in the hiragana instead of kanji, then the pronunciation will match the hiragana. However, then we will have more pitch accent errors because we lose pitch accent information if we only pass in hiragana. A solution would be to add a settings option which can be toggled to play the hiragana instead of the kanji if a user cares more about the hiragana being played than the pitch accent being correct. Another solution would be to change the hiragana so the text-to-speech of the kanji matches the hiragana. Another solution would be to just remove words where the text-to-speech of the kanji doesn't match the hiragana. This would take a lot of time since there are thousands of words and the text-to-speech was relatively accurate so I decided to just not do anything. I also agree that the styling could probably be improved a little bit :) Adding sentences would be good so the words could be learned in context but this might take a while since there are thousands of words. Maybe a simple solution to this would be to use an API which provides example sentences for each word. |
I as a expected it was generated automatically. (No offense please). I have a decent level of Japanese, and I would be willing to help if you want, but I don't know tailwind CSS, how i can do it? I don't have much of time because I have a full time work, so you know. |
For the styling, what specifically were you trying to change? Feel free to show screenshots. |
Dunno, I'm not a frontend expert but, I feel it's too clutered, I think it needs more space I guess, what you think? |
I increased the spacing in this pull request: #4 |
LGTM, regarding the other things, you have plans? I mean, it's just a suggestion. |
I'll look into the text-to-speech settings for Chrome's API to see if I can get more accurate pronunciation for Japanese |
Hello, your app is a awesome idea, but I have a few points on your application.
is the audio narrated by a human or it's TTS? another: some words have mismatched audio eg: are 開く (read as あく) in the audio being told ひらく, a whole different word.
Other than your application is really nice, but I think that the styles can be more... spaced I guess.
Other than I would add sentences as well.
Kind regards.
The text was updated successfully, but these errors were encountered: