Update rest_api_base.py #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TableauRestApiBase36 does not initialise TableauRestAPIBase (commented out) I'm not 100% sure why, assume it has something to do with the implementation of personal access tokens. add_user_by_username() in user.py validates the specified site_role against the tuple of allowed site_roles as defined in TableauRestAPIBase which doesn't get initialised for versions after 3.6. Adding this tuple to TableauRestApiBase36 Would be good to understand better why the chain of inheritance is broken in 3.6?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableauRestApiBase36 does not initialise TableauRestAPIBase (commented out) I'm not 100% sure why, assume it has something to do with the implementation of personal access tokens.
add_user_by_username() in user.py validates the specified site_role against the tuple of allowed site_roles as defined in TableauRestAPIBase which doesn't get initialised for versions after 3.6. Adding this tuple to TableauRestApiBase36
Would be good to understand better why the chain of inheritance is broken in 3.6?