Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with Jenkins #79

Open
theincredibleguy opened this issue Jun 2, 2014 · 10 comments
Open

integration with Jenkins #79

theincredibleguy opened this issue Jun 2, 2014 · 10 comments

Comments

@theincredibleguy
Copy link

How can I integrate the dpxdt with Jenkins as I intend to use the visualization diff as a part of CI?

Regards.

@bslatkin
Copy link
Owner

bslatkin commented Jun 3, 2014

I'd try to use one of these tools:

Diff my urls: You provide a set of URLs for your current build vs. baseline and kick off a new dpxdt run from the Jenkins workflow:
https://github.com/bslatkin/dpxdt#diff-my-urls

Diff my images: You captured your own images (e.g., using Selenium) and upload them from Jenkins using a script like this:
https://github.com/bslatkin/dpxdt#diff-my-images

@theincredibleguy
Copy link
Author

I will be able to integrate this in the CI pipeline, however, there's just one predicament; a manual action required to approve the build. Is there a way to automate the approval if there's no difference?

@bslatkin
Copy link
Owner

bslatkin commented Jun 6, 2014

That sounds like a pretty easy thing to add. I wonder if it should just be the default. When the build is approved, will you take some other action in your CI pipeline? There's currently no "output" from approving a build. Nothing like a webhook or even an API to poll for when the state of a build changes. I wonder if you'd need that too?

@theincredibleguy
Copy link
Author

There are a couple more stages in the CI pipeline, one of the important tasks is generation of reports on the basis of the diff results. So it would be nice to have an API around the same. Also, I was wondering why isn't build marked as good when there's no difference between the snapshots. Do you have any use cases where there could be a conflict in this regard?

@bslatkin
Copy link
Owner

bslatkin commented Jun 6, 2014

The one case I've seen is where the test and staging versions both respond with 500s for every URL or something like that, so though the images all match and there are no diffs, the actual tests were worthless. I'm not quite sure how to guard against that.

@slmoloch
Copy link

Is there any API to get list of builds and their statuses planned? I want to integrate ThoughtWorks Go with dpxdt and it seems the missing piece of the puzzle.

@hutchic
Copy link

hutchic commented Jan 23, 2015

There's currently no "output" from approving a build. Nothing like a webhook or even an API to poll for when the state of a build changes. I wonder if you'd need that too?

Not to drag old conversations up but this would be a great addition any chance it could get included at some point?

@bslatkin
Copy link
Owner

@hutchic Thanks for the feedback. Could you explain how you'd like the API to work? I could use some guidance on the details. Are you okay with polling for statuses of builds like @slmoloch described?

@hutchic
Copy link

hutchic commented Feb 11, 2015

polling would work web hook would be better (IMHO) :)

@elsigh
Copy link
Collaborator

elsigh commented Apr 21, 2015

+1 for webhook - I want one in general for posting back to our deploy slack channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants