Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Editable Places? #7

Open
jseppi opened this issue May 13, 2015 · 2 comments
Open

Editable Places? #7

jseppi opened this issue May 13, 2015 · 2 comments

Comments

@jseppi
Copy link
Contributor

jseppi commented May 13, 2015

Hey @bsudekum, I was thinking it would be nice if the list of places were editable. My own use case was wanting to have Austin be one of the random maps, but it is not in https://github.com/mapbox/gazetteer and I'm not sure you all want people adding their own pet places to that project.

I'd be happy to draft a pull request with an implementation if you think it is a reasonable idea. Screenshots below show what I'm thinking.

image

image

Perhaps editing JSON is too much though. A simpler option could be to have a button to add current map location to places.

@bsudekum
Copy link
Owner

Yeah this looks good. For reference, places are coming from https://github.com/mapbox/gazetteer.

Some thoughts:

  • I wonder if a csv style delimitation would be easier for people to read and to add to
lat, lng
0, 0
20, 30
50, 60
20, 20
  • Place name is not required, and actually should not be included
  • We might want to put a limit on how many people can add especially if this is going to stored in a cookie.

@jseppi
Copy link
Contributor Author

jseppi commented May 19, 2015

Cool, thanks for the feedback. I agree simple Lat, Lng would be better.
Maybe zoom as well?
I'll get to putting it together.
On May 18, 2015 7:48 PM, "Bobby Sudekum" [email protected] wrote:

Yeah this looks good. For reference, places are coming from
https://github.com/mapbox/gazetteer.

Some thoughts:

  • I wonder if a csv style delimitation would be easier for people to
    read and to add to

lat, lng
0, 0
20, 30
50, 60
20, 20

  • Place name is not required, and actually should not be included
  • We might want to put a limit on how many people can add especially
    if this is going to stored in a cookie.


Reply to this email directly or view it on GitHub
#7 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants