Coding style (use 0.0f instead of just 0), turned on a bunch of warnings (and then fixed them).

Author: btrask

NSBezierPathAdditions.m

@@ -35,10 +35,10 @@ + (NSBezierPath *)AE_bezierPathWithRoundRect:(NSRect)aRect
                   cornerRadius:(float)radius
 {
 	NSBezierPath *const path = [self bezierPath];
-	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(aRect) - radius, NSMaxY(aRect) - radius) radius:radius startAngle:0 endAngle:90];
-	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(aRect) + radius, NSMaxY(aRect) - radius) radius:radius startAngle:90 endAngle:180];
-	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(aRect) + radius, NSMinY(aRect) + radius) radius:radius startAngle:180 endAngle:270];
-	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(aRect) - radius, NSMinY(aRect) + radius) radius:radius startAngle:270 endAngle:0];
+	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(aRect) - radius, NSMaxY(aRect) - radius) radius:radius startAngle:0.0f endAngle:90.0f];
+	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(aRect) + radius, NSMaxY(aRect) - radius) radius:radius startAngle:90.0f endAngle:180.0f];
+	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(aRect) + radius, NSMinY(aRect) + radius) radius:radius startAngle:180.0f endAngle:270.0f];
+	[path appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(aRect) - radius, NSMinY(aRect) + radius) radius:radius startAngle:270.0f endAngle:0.0f];
 	[path closePath];
 	return path;
 }
@@ -50,15 +50,15 @@ + (void)AE_drawIcon:(AEIconType)type
 	switch(type) {
 		case AEPlayIcon:
 		{
-			float const r = scale / 10;
-			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(b) - r, NSMidY(b)) radius:r startAngle:60 endAngle:-60 clockwise:YES];
-			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.1f + r, NSMinY(b) + NSHeight(b) * 0.05f + r * 1.0f) radius:r startAngle:-60 endAngle:180 clockwise:YES];
-			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.1f + r, NSMinY(b) + NSHeight(b) * 0.95f - r * 1.0f) radius:r startAngle:180 endAngle:60 clockwise:YES];
+			float const r = scale / 10.0f;
+			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMaxX(b) - r, NSMidY(b)) radius:r startAngle:60.0f endAngle:-60.0f clockwise:YES];
+			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.1f + r, NSMinY(b) + NSHeight(b) * 0.05f + r * 1.0f) radius:r startAngle:-60.0f endAngle:180.0f clockwise:YES];
+			[p appendBezierPathWithArcWithCenter:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.1f + r, NSMinY(b) + NSHeight(b) * 0.95f - r * 1.0f) radius:r startAngle:180.0f endAngle:60.0f clockwise:YES];
 			[p fill];
 			break;
 		}
 		case AEPauseIcon:
-			[p setLineWidth:scale / 4];
+			[p setLineWidth:scale / 4.0f];
 			[p setLineCapStyle:NSRoundLineCapStyle];
 			[p moveToPoint:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.25f, NSMinY(b) + NSHeight(b) * 0.85f)];
 			[p lineToPoint:NSMakePoint(NSMinX(b) + NSWidth(b) * 0.25f, NSMinY(b) + NSHeight(b) * 0.15f)];
@@ -75,12 +75,12 @@ + (void)AE_drawIcon:(AEIconType)type
 + (void)AE_drawSpinnerInRect:(NSRect)r
         startAtPetal:(int)petal
 {
-	[NSBezierPath setDefaultLineWidth:MIN(NSWidth(r), NSHeight(r)) / 11];
+	[NSBezierPath setDefaultLineWidth:MIN(NSWidth(r), NSHeight(r)) / 11.0f];
 	[NSBezierPath setDefaultLineCapStyle:NSRoundLineCapStyle];
 	unsigned i = 0;
 	for(; i < 12; i++) {
-		[[[NSColor AE_bezelForegroundColor] colorWithAlphaComponent:petal < 0 ? 0.1f : ((petal + i) % 12) / -12.0f + 1] set];
-		[NSBezierPath strokeLineFromPoint:NSMakePoint(NSMidX(r) + cosf(pi * 2.0f * i / 12.0f) * NSWidth(r) / 4.0f, NSMidY(r) + sinf(pi * 2.0f * i / 12.0f) * NSHeight(r) / 4.0f) toPoint:NSMakePoint(NSMidX(r) + cosf(pi * 2.0f * i / 12.0f) * NSWidth(r) / 2.0f, NSMidY(r) + sinf(pi * 2.0f * i / 12.0f) * NSHeight(r) / 2.0f)];
+		[[[NSColor AE_bezelForegroundColor] colorWithAlphaComponent:petal < 0.0f ? 0.1f : ((petal + i) % 12) / -12.0f + 1.0f] set];
+		[NSBezierPath strokeLineFromPoint:NSMakePoint(NSMidX(r) + cosf((float)pi * 2.0f * i / 12.0f) * NSWidth(r) / 4.0f, NSMidY(r) + sinf((float)pi * 2.0f * i / 12.0f) * NSHeight(r) / 4.0f) toPoint:NSMakePoint(NSMidX(r) + cosf((float)pi * 2.0f * i / 12.0f) * NSWidth(r) / 2.0f, NSMidY(r) + sinf((float)pi * 2.0f * i / 12.0f) * NSHeight(r) / 2.0f)];
 	}
 	[NSBezierPath setDefaultLineWidth:1];
 	[NSBezierPath setDefaultLineCapStyle:NSMiterLineJoinStyle];

NSColorAdditions.m

@@ -24,16 +24,16 @@
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
 #import "NSColorAdditions.h"
 
-#define PGCheckerboardSquareSize 8
-#define PGCheckerboardSize (PGCheckerboardSquareSize * 2)
+#define PGCheckerboardSquareSize 8.0f
+#define PGCheckerboardSize (PGCheckerboardSquareSize * 2.0f)
 
 @implementation NSColor (AEAdditions)
 
 #pragma mark +NSColor(AEAdditions)
 
 + (NSColor *)AE_bezelBackgroundColor
 {
-	return [NSColor colorWithDeviceWhite:(48.0f / 255.0f) alpha:0.75f];
+	return [NSColor colorWithDeviceWhite:48.0f / 255.0f alpha:0.75f];
 }
 + (NSColor *)AE_bezelForegroundColor
 {
@@ -47,13 +47,13 @@ - (NSColor *)AE_checkerboardPatternColor
 	NSImage *const checkerboard = [[[NSImage alloc] initWithSize:NSMakeSize(PGCheckerboardSize, PGCheckerboardSize)] autorelease];
 	[checkerboard lockFocus];
 	[self set];
-	NSRectFill(NSMakeRect(0, 0, PGCheckerboardSize, PGCheckerboardSize));
-	[[NSColor colorWithDeviceWhite:1 alpha:0.07] set];
+	NSRectFill(NSMakeRect(0.0f, 0.0f, PGCheckerboardSize, PGCheckerboardSize));
+	[[NSColor colorWithDeviceWhite:1.0f alpha:0.07f] set];
 	NSRectFillUsingOperation(NSMakeRect(0, 0, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
 	NSRectFillUsingOperation(NSMakeRect(PGCheckerboardSquareSize, PGCheckerboardSquareSize, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
-	[[NSColor colorWithDeviceWhite:0 alpha:0.07] set];
-	NSRectFillUsingOperation(NSMakeRect(0, PGCheckerboardSquareSize, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
-	NSRectFillUsingOperation(NSMakeRect(PGCheckerboardSquareSize, 0, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
+	[[NSColor colorWithDeviceWhite:0.0f alpha:0.07f] set];
+	NSRectFillUsingOperation(NSMakeRect(0.0f, PGCheckerboardSquareSize, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
+	NSRectFillUsingOperation(NSMakeRect(PGCheckerboardSquareSize, 0.0f, PGCheckerboardSquareSize, PGCheckerboardSquareSize), NSCompositeSourceOver);
 	[checkerboard unlockFocus];
 	return [NSColor colorWithPatternImage:checkerboard];
 }

NSWindowAdditions.m

@@ -33,7 +33,7 @@ - (BOOL)AE_isVisible
 }
 - (float)AE_userSpaceScaleFactor
 {
-	return [self respondsToSelector:@selector(userSpaceScaleFactor)] ? [self userSpaceScaleFactor] : 1.0;
+	return [self respondsToSelector:@selector(userSpaceScaleFactor)] ? [self userSpaceScaleFactor] : 1.0f;
 }
 - (NSRect)AE_contentRect
 {

PGActivityPanelController.m

@@ -32,6 +32,7 @@
 
 // Other
 #import "PGDelayedPerforming.h"
+#import "PGGeometry.h"
 
 // Categories
 #import "NSObjectAdditions.h"
@@ -92,7 +93,7 @@ - (id)outlineView:(NSOutlineView *)outlineView
 		static NSDictionary *attrs = nil;
 		if(!attrs) {
 			NSMutableParagraphStyle *const style = [[[NSParagraphStyle defaultParagraphStyle] mutableCopy] autorelease];
-			[style setTighteningFactorForTruncation:0.3];
+			[style setTighteningFactorForTruncation:0.3f];
 			[style setLineBreakMode:NSLineBreakByTruncatingMiddle];
 			attrs = [[NSDictionary alloc] initWithObjectsAndKeys:style, NSParagraphStyleAttributeName, nil];
 		}
@@ -124,7 +125,7 @@ - (void)outlineViewSelectionDidChange:(NSNotification *)notification
 
 - (void)windowWillShow
 {
-	_updateTimer = [[self PG_performSelector:@selector(_update) withObject:nil fireDate:nil interval:1.0f / 12.0f options:PGRetainTarget] retain];
+	_updateTimer = [[self PG_performSelector:@selector(_update) withObject:nil fireDate:nil interval:PGAnimationFramerate / 2.0f options:PGRetainTarget] retain];
 	[self _update];
 }
 - (void)windowDidClose

PGAlertView.m

@@ -37,7 +37,7 @@
 #import "NSObjectAdditions.h"
 
 #define PGAlertViewSize 100.0f
-#define PGMarginSize 4.0
+#define PGMarginSize 4.0f
 
 @interface PGAlertView (Private)
 
@@ -74,7 +74,7 @@ - (void)pushGraphic:(PGAlertGraphic *)aGraphic
 		[self _updateCurrentGraphic];
 	}
 	NSTimeInterval const fadeOutDelay = [_currentGraphic fadeOutDelay];
-	if(fadeOutDelay >= 0.01) [self PG_performSelector:@selector(popGraphicIdenticalTo:) withObject:_currentGraphic fireDate:nil interval:-fadeOutDelay options:PGCompareArgumentPointer];
+	if(fadeOutDelay >= 0.01f) [self PG_performSelector:@selector(popGraphicIdenticalTo:) withObject:_currentGraphic fireDate:nil interval:-fadeOutDelay options:PGCompareArgumentPointer];
 	if(window && [[self window] respondsToSelector:@selector(displayOverWindow:)]) [(PGBezelPanel *)[self window] displayOverWindow:window];
 }
 - (void)popGraphic:(PGAlertGraphic *)aGraphic
@@ -138,7 +138,7 @@ - (void)_updateCurrentGraphic
 	[_frameTimer invalidate];
 	_frameCount = 0;
 	NSTimeInterval const animationDelay = [_currentGraphic animationDelay];
-	_frameTimer = animationDelay > 0 ? [self PG_performSelector:@selector(animateOneFrame:) withObject:self fireDate:nil interval:animationDelay options:PGRetainTarget] : nil;
+	_frameTimer = animationDelay > 0.0f ? [self PG_performSelector:@selector(animateOneFrame:) withObject:self fireDate:nil interval:animationDelay options:PGRetainTarget] : nil;
 	[self setNeedsDisplay:YES];
 }
 
@@ -259,22 +259,22 @@ - (void)drawInView:(PGAlertView *)anAlertView
 		[[NSColor AE_bezelBackgroundColor] set];
 		NSBezierPath *const path = [NSBezierPath bezierPath];
 		[path moveToPoint:centers[i]];
-		[path appendBezierPathWithArcWithCenter:centers[i] radius:50.0f * f startAngle:90 * i endAngle:90 * (i + 1)];
+		[path appendBezierPathWithArcWithCenter:centers[i] radius:50.0f * f startAngle:90.0f * i endAngle:90.0f * (i + 1)];
 		[path closePath];
 		[path fill];
 	}
 
 	NSShadow *const shadow = [[[NSShadow alloc] init] autorelease];
-	[shadow setShadowBlurRadius:4];
-	[shadow setShadowOffset:NSMakeSize(0, -1)];
+	[shadow setShadowBlurRadius:4.0f];
+	[shadow setShadowOffset:NSMakeSize(0.0f, -1.0f)];
 	[shadow setShadowColor:[NSColor blackColor]];
 	[shadow set];
 }
 - (void)flipHorizontally
 {
 	NSAffineTransform *const flip = [[[NSAffineTransform alloc] init] autorelease];
-	[flip translateXBy:PGAlertViewSize yBy:0];
-	[flip scaleXBy:-1 yBy:1];
+	[flip translateXBy:PGAlertViewSize yBy:0.0f];
+	[flip scaleXBy:-1.0f yBy:1.0f];
 	[flip concat];
 }
 - (NSTimeInterval)fadeOutDelay
@@ -286,7 +286,7 @@ - (NSTimeInterval)fadeOutDelay
 
 - (NSTimeInterval)animationDelay
 {
-	return 0;
+	return 0.0f;
 }
 - (unsigned)frameMax
 {
@@ -321,15 +321,15 @@ - (void)drawInView:(PGAlertView *)anAlertView
 	[[NSColor AE_bezelForegroundColor] set];
 
 	NSBezierPath *const arrow = [NSBezierPath bezierPath];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(180.0f * f, 150.0f * f) radius:large startAngle:315 endAngle:45];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(140.0f * f, 200.0f * f) radius:small startAngle:45 endAngle:90];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(125.0f * f, 200.0f * f) radius:small startAngle:90 endAngle:180];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(115.0f * f, 180.0f * f) radius:small startAngle:0 endAngle:270 clockwise:YES];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint( 75.0f * f, 170.0f * f) radius:small startAngle:90 endAngle:180];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint( 75.0f * f, 130.0f * f) radius:small startAngle:180 endAngle:270];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(115.0f * f, 120.0f * f) radius:small startAngle:90 endAngle:0 clockwise:YES];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(125.0f * f, 100.0f * f) radius:small startAngle:180 endAngle:270];
-	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(140.0f * f, 100.0f * f) radius:small startAngle:270 endAngle:315];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(180.0f * f, 150.0f * f) radius:large startAngle:315.0f endAngle:45.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(140.0f * f, 200.0f * f) radius:small startAngle:45.0f endAngle:90.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(125.0f * f, 200.0f * f) radius:small startAngle:90.0f endAngle:180.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(115.0f * f, 180.0f * f) radius:small startAngle:0.0f endAngle:270.0f clockwise:YES];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint( 75.0f * f, 170.0f * f) radius:small startAngle:90.0f endAngle:180.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint( 75.0f * f, 130.0f * f) radius:small startAngle:180.0f endAngle:270.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(115.0f * f, 120.0f * f) radius:small startAngle:90.0f endAngle:0.0f clockwise:YES];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(125.0f * f, 100.0f * f) radius:small startAngle:180.0f endAngle:270.0f];
+	[arrow appendBezierPathWithArcWithCenter:NSMakePoint(140.0f * f, 100.0f * f) radius:small startAngle:270.0f endAngle:315.0f];
 	[arrow fill];
 
 	NSBezierPath *const wall = [NSBezierPath bezierPath];
@@ -420,7 +420,7 @@ - (float)progress
 }
 - (void)setProgress:(float)progress
 {
-	_progress = MIN(MAX(progress, 0), 1);
+	_progress = MIN(MAX(progress, 0.0f), 1.0f);
 }
 
 #pragma mark NSObject Protocol
@@ -460,7 +460,7 @@ - (NSTimeInterval)fadeOutDelay
 
 - (NSTimeInterval)animationDelay
 {
-	return 1.0 / 12.0;
+	return 1.0f / 12.0f;
 }
 - (unsigned)frameMax
 {

PGArchiveAdapter.m

@@ -230,7 +230,7 @@ - (NSStringEncoding)archive:(XADArchive *)archive
                     guess:(NSStringEncoding)guess
                     confidence:(float)confidence
 {
-	if(confidence < 0.8 && !_encodingError) {
+	if(confidence < 0.8f && !_encodingError) {
 		_encodingError = YES;
 		[[self node] setError:[NSError errorWithDomain:PGNodeErrorDomain code:PGEncodingError userInfo:[NSDictionary dictionaryWithObjectsAndKeys:[NSData dataWithBytes:bytes length:strlen(bytes)], PGUnencodedStringDataKey, [NSNumber numberWithUnsignedInt:guess], PGDefaultEncodingKey, nil]]];
 		[[self node] loadFinished];

PGAttachments.m

@@ -87,7 +87,7 @@ - (void)drawWithFrame:(NSRect)aRect
 {
 	NSImage *const image = [NSImage imageNamed:[self imageNameHighlighted:highlighted]];
 	[image setFlipped:YES];
-	[image drawInRect:aRect fromRect:NSZeroRect operation:NSCompositeSourceOver fraction:(enabled ? 1.0 : 0.5)];
+	[image drawInRect:aRect fromRect:NSZeroRect operation:NSCompositeSourceOver fraction:enabled ? 1.0f : 0.5f];
 }
 - (NSString *)imageNameHighlighted:(BOOL)flag
 {
@@ -110,11 +110,11 @@ - (void)drawWithFrame:(NSRect)aRect
 }
 - (NSSize)cellSize
 {
-	return NSMakeSize(16, 16);
+	return NSMakeSize(16.0f, 16.0f);
 }
 - (NSPoint)cellBaselineOffset
 {
-	return NSMakePoint(0, -3);
+	return NSMakePoint(0.0f, -3.0f);
 }
 
 @end
@@ -151,16 +151,16 @@ - (void)drawWithFrame:(NSRect)aRect
 	[NSGraphicsContext saveGraphicsState];
 	[[NSGraphicsContext currentContext] setImageInterpolation:NSImageInterpolationHigh];
 	[[self image] setFlipped:YES];
-	[[self image] drawInRect:aRect fromRect:NSZeroRect operation:NSCompositeSourceOver fraction:1.0];
+	[[self image] drawInRect:aRect fromRect:NSZeroRect operation:NSCompositeSourceOver fraction:1.0f];
 	[NSGraphicsContext restoreGraphicsState];
 }
 - (NSSize)cellSize
 {
-	return NSMakeSize(16, 16);
+	return NSMakeSize(16.0f, 16.0f);
 }
 - (NSPoint)cellBaselineOffset
 {
-	return NSMakePoint(0, -3);
+	return NSMakePoint(0.0f, -3.0f);
 }
 
 #pragma mark NSCell