Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven jar use jdk 1.8? #3

Open
haochun opened this issue Oct 25, 2017 · 2 comments
Open

maven jar use jdk 1.8? #3

haochun opened this issue Oct 25, 2017 · 2 comments

Comments

@haochun
Copy link

haochun commented Oct 25, 2017

can you compile use jdk 1.6+ or jdk 1.7+?
@eroux
Copy link
Collaborator

eroux commented Oct 25, 2017

Well, why not, can you please make a pull request with the required changes? certainly at least a modification of pom.xml and maybe some minor changes due to the change of java version... But I would like to targer 1.7, not 1.6 if possible. wdyt?

@haochun
Copy link
Author

haochun commented Oct 25, 2017

i think 1.7 is ok.i will pull a request tomorrow.but,i maybe to change you code.the unit test use String.jion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eroux @haochun