Create seemingly necessary subcompositor #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous name: "Make diplay info info" I believe that to be a far more concise and succinct message. Buffet voiced their concerns about informational content, which I must vehemently disagree with. The inclusion of "logging" as a concept in the commit message I see as an entirely superfluous and honestly insulting statement to the programmer's intelligence. To assume that someone would fail to infer that "making something info" is to log it as info is blatantly derogatory. Nonetheless I believe this commit to be important enough to future developer experience to contribute this despite the terrible overreach by the original developer of kiwmi. To hope that this incident is not to be forgotten. Acked-by: buffet <[email protected]>
gwimm
force-pushed
the
wlr_subcompositor
branch
from
d93c706
to
c76d257
Compare
gwimm
force-pushed
the
wlr_subcompositor
branch
from
c76d257
to
816625b
Compare
|
The subcompositor not being created is a breaking change that wlroots 0.16.0 introduced: https://gitlab.freedesktop.org/wlroots/wlroots/-/releases/0.16.0:
As such, this should not be a separate PR, but included together with #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both alacritty and foot want them, tinywl does it, so kiwmi now does it.