Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bedrock #45

Open
sebsto opened this issue Oct 11, 2023 · 6 comments
Open

Add support for Bedrock #45

sebsto opened this issue Oct 11, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@sebsto
Copy link

sebsto commented Oct 11, 2023

I am new to this project and still learning the ropes :-)
What would be required to add support for Amazon Bedrock, like https://python.langchain.com/docs/integrations/llms/bedrock

Happy to contribute with a PR

@buhe
Copy link
Owner

buhe commented Oct 12, 2023

Thank you!
Looking forward to your PR, if there is anything need help please do not hesitate to say.

@buhe buhe added the enhancement New feature or request label Oct 12, 2023
@buhe
Copy link
Owner

buhe commented Oct 12, 2023

I've used https://github.com/soto-project/soto and hope it helps

@sebsto
Copy link
Author

sebsto commented Oct 12, 2023

@buhe that was my next question. This PR would bring a very large dependency in.
I was planning to use the AWS SDK for Swift (https://github.com/awslabs/aws-sdk-swift), Soto would work too if it has been updated to include Bedrock API.
I also have a "mini-SDK" working, just for Bedrock, with just one dependency to generate the AWS signature in the header. This is much lighter but would require to manually add Bedrock API if they are going to add more in the future.

My preference in terms of future maintainability is to bring in the AWS SDK for Swift. But that will significantly increase swift package resolve and swift build time for everybody.

What do you think ?

@buhe
Copy link
Owner

buhe commented Oct 13, 2023

I also feel that the AWS SDK should be introduced as a dependency. As for the size, and at some point later we can split the project into langchain-swift, langchain-swift-ext1, langchain-swift-ext2. Langchain-swift as the core contains superclass and basic implementation, the rest can be put into langchain-swift-ext1 and dependency on langchain-swift, so that users can choose for themselves.

What do you think?

@buhe
Copy link
Owner

buhe commented Oct 30, 2023

@sebsto Is there anything I can do to help?

@sebsto
Copy link
Author

sebsto commented Oct 30, 2023

@buhe - I am busy at work until Dec. 7th. Will test and report here after that date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants