Skip to content

Commit f74342a

Browse files
committed
Depend on remote-apis as a Bazel module
remote-apis just switched to bzlmod. This change patches up bb-storage to depend on it as a module, instead of pulling it in via Gazelle. Right now this still requires us to apply a local patch, because the go_proto_library() targets in remote-apis use the old gRPC v1 compiler for generating sources. See this PR for more details: bazelbuild/remote-apis#308
1 parent 45c5763 commit f74342a

File tree

29 files changed

+609
-107
lines changed

29 files changed

+609
-107
lines changed

Diff for: BUILD.bazel

+4-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ load("@gazelle//:def.bzl", "gazelle")
44

55
# gazelle:go_grpc_compilers @rules_go//proto:go_proto,@rules_go//proto:go_grpc_v2
66
# gazelle:prefix github.com/buildbarn/bb-storage
7-
# gazelle:resolve proto build/bazel/remote/execution/v2/remote_execution.proto @com_github_bazelbuild_remote_apis//build/bazel/remote/execution/v2:remote_execution_proto
8-
# gazelle:resolve proto go build/bazel/remote/execution/v2/remote_execution.proto @com_github_bazelbuild_remote_apis//build/bazel/remote/execution/v2:execution
7+
# gazelle:resolve go github.com/bazelbuild/remote-apis/build/bazel/remote/execution/v2 @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_go_proto
8+
# gazelle:resolve go github.com/bazelbuild/remote-apis/build/bazel/semver @bazel_remote_apis//build/bazel/semver:semver_go_proto
9+
# gazelle:resolve proto build/bazel/remote/execution/v2/remote_execution.proto @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_proto
10+
# gazelle:resolve proto go build/bazel/remote/execution/v2/remote_execution.proto @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_go_proto
911
# gazelle:resolve proto go google/bytestream/bytestream.proto @org_golang_google_genproto_googleapis_bytestream//:bytestream
1012
# gazelle:resolve proto go google/rpc/status.proto @org_golang_google_genproto_googleapis_rpc//status
1113
# gazelle:resolve proto go opentelemetry/proto/common/v1/common.proto @io_opentelemetry_go_proto_otlp//common/v1:common

Diff for: MODULE.bazel

+8-15
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ module(name = "com_github_buildbarn_bb_storage")
22

33
bazel_dep(name = "aspect_bazel_lib", version = "2.8.1")
44
bazel_dep(name = "aspect_rules_js", version = "2.0.1")
5+
bazel_dep(name = "bazel_remote_apis", version = "0.0.0")
56
bazel_dep(name = "gazelle", version = "0.38.0")
67
bazel_dep(name = "googleapis", version = "0.0.0-20240326-1c8d509c5")
78
bazel_dep(name = "jsonnet_go", version = "0.20.0")
@@ -14,6 +15,13 @@ bazel_dep(name = "rules_pkg", version = "1.0.1")
1415
bazel_dep(name = "rules_proto", version = "6.0.2")
1516
bazel_dep(name = "toolchains_llvm", version = "1.1.2")
1617

18+
git_override(
19+
module_name = "bazel_remote_apis",
20+
commit = "9a250a0f817fe63a426ede43b133c3dc4549d75f",
21+
patches = ["//:patches/bazel_remote_apis/grpc-v2.diff"],
22+
remote = "https://github.com/bazelbuild/remote-apis.git",
23+
)
24+
1725
git_override(
1826
module_name = "gazelle",
1927
commit = "4d0129d7adae33e8e648d3624aff8fa8f93f375b",
@@ -39,7 +47,6 @@ use_repo(
3947
"com_github_aws_aws_sdk_go_v2_service_s3",
4048
"com_github_aws_aws_sdk_go_v2_service_sts",
4149
"com_github_bazelbuild_buildtools",
42-
"com_github_bazelbuild_remote_apis",
4350
"com_github_fxtlabs_primes",
4451
"com_github_go_jose_go_jose_v3",
4552
"com_github_google_uuid",
@@ -78,20 +85,6 @@ use_repo(
7885
)
7986

8087
go_deps_dev = use_extension("@gazelle//:extensions.bzl", "go_deps", dev_dependency = True)
81-
go_deps_dev.gazelle_override(
82-
build_file_generation = "on",
83-
directives = [
84-
"gazelle:go_grpc_compilers @io_bazel_rules_go//proto:go_proto,@io_bazel_rules_go//proto:go_grpc_v2",
85-
"gazelle:resolve proto go build/bazel/semver/semver.proto //build/bazel/semver",
86-
"gazelle:resolve proto go google/api/annotations.proto @org_golang_google_genproto_googleapis_api//annotations",
87-
"gazelle:resolve proto go google/longrunning/operations.proto @com_google_cloud_go_longrunning//autogen/longrunningpb",
88-
"gazelle:resolve proto go google/rpc/status.proto @org_golang_google_genproto_googleapis_rpc//status",
89-
"gazelle:resolve proto google/api/annotations.proto @googleapis//google/api:annotations_proto",
90-
"gazelle:resolve proto google/longrunning/operations.proto @googleapis//google/longrunning:operations_proto",
91-
"gazelle:resolve proto google/rpc/status.proto @googleapis//google/rpc:status_proto",
92-
],
93-
path = "github.com/bazelbuild/remote-apis",
94-
)
9588
go_deps_dev.module_override(
9689
patches = ["//:patches/com_github_grpc_ecosystem_go_grpc_prometheus/client-metrics-prevent-handled-twice.diff"],
9790
path = "github.com/grpc-ecosystem/go-grpc-prometheus",

Diff for: MODULE.bazel.lock

+388-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: cmd/bb_storage/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ go_library(
2121
"//pkg/proto/icas",
2222
"//pkg/proto/iscc",
2323
"//pkg/util",
24-
"@com_github_bazelbuild_remote_apis//build/bazel/remote/execution/v2:execution",
24+
"@bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_go_proto",
2525
"@org_golang_google_genproto_googleapis_bytestream//:bytestream",
2626
"@org_golang_google_grpc//:grpc",
2727
"@org_golang_google_grpc//codes",

Diff for: go.mod

+32-32
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ require (
99
cloud.google.com/go/longrunning v0.6.0
1010
cloud.google.com/go/storage v1.43.0
1111
github.com/aohorodnyk/mimeheader v0.0.6
12-
github.com/aws/aws-sdk-go-v2 v1.30.4
13-
github.com/aws/aws-sdk-go-v2/config v1.27.31
14-
github.com/aws/aws-sdk-go-v2/credentials v1.17.30
15-
github.com/aws/aws-sdk-go-v2/service/s3 v1.61.0
16-
github.com/aws/aws-sdk-go-v2/service/sts v1.30.5
12+
github.com/aws/aws-sdk-go-v2 v1.30.5
13+
github.com/aws/aws-sdk-go-v2/config v1.27.33
14+
github.com/aws/aws-sdk-go-v2/credentials v1.17.32
15+
github.com/aws/aws-sdk-go-v2/service/s3 v1.61.2
16+
github.com/aws/aws-sdk-go-v2/service/sts v1.30.7
1717
github.com/bazelbuild/buildtools v0.0.0-20240827154017-dd10159baa91
18-
github.com/bazelbuild/remote-apis v0.0.0-20240703191324-0d21f29acdb9
18+
github.com/bazelbuild/remote-apis v0.0.0-20240910125346-9a250a0f817f
1919
github.com/fxtlabs/primes v0.0.0-20150821004651-dad82d10a449
2020
github.com/go-jose/go-jose/v3 v3.0.3
2121
github.com/google/go-jsonnet v0.20.0
@@ -26,9 +26,9 @@ require (
2626
github.com/jmespath/go-jmespath v0.4.0
2727
github.com/klauspost/compress v1.17.9
2828
github.com/lazybeaver/xorshift v0.0.0-20170702203709-ce511d4823dd
29-
github.com/prometheus/client_golang v1.20.2
29+
github.com/prometheus/client_golang v1.20.3
3030
github.com/prometheus/client_model v0.6.1
31-
github.com/prometheus/common v0.57.0
31+
github.com/prometheus/common v0.59.1
3232
github.com/sercand/kuberesolver/v5 v5.1.1
3333
github.com/stretchr/testify v1.9.0
3434
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.54.0
@@ -41,36 +41,36 @@ require (
4141
go.opentelemetry.io/proto/otlp v1.3.1
4242
go.uber.org/mock v0.4.0
4343
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
44-
golang.org/x/oauth2 v0.22.0
44+
golang.org/x/oauth2 v0.23.0
4545
golang.org/x/sync v0.8.0
46-
golang.org/x/sys v0.24.0
47-
google.golang.org/api v0.195.0
48-
google.golang.org/genproto/googleapis/bytestream v0.0.0-20240827150818-7e3bb234dfed
49-
google.golang.org/genproto/googleapis/rpc v0.0.0-20240827150818-7e3bb234dfed
50-
google.golang.org/grpc v1.66.0
46+
golang.org/x/sys v0.25.0
47+
google.golang.org/api v0.196.0
48+
google.golang.org/genproto/googleapis/bytestream v0.0.0-20240903143218-8af14fe29dc1
49+
google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1
50+
google.golang.org/grpc v1.66.1
5151
google.golang.org/grpc/security/advancedtls v1.0.0
5252
google.golang.org/protobuf v1.34.2
5353
mvdan.cc/gofumpt v0.7.0
5454
)
5555

5656
require (
5757
cloud.google.com/go v0.115.1 // indirect
58-
cloud.google.com/go/auth v0.9.2 // indirect
58+
cloud.google.com/go/auth v0.9.3 // indirect
5959
cloud.google.com/go/auth/oauth2adapt v0.2.4 // indirect
6060
cloud.google.com/go/compute/metadata v0.5.0 // indirect
6161
cloud.google.com/go/iam v1.2.0 // indirect
6262
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.4 // indirect
63-
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12 // indirect
64-
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16 // indirect
65-
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16 // indirect
63+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.13 // indirect
64+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.17 // indirect
65+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.17 // indirect
6666
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
67-
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.16 // indirect
67+
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.17 // indirect
6868
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4 // indirect
69-
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.18 // indirect
70-
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18 // indirect
71-
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.16 // indirect
72-
github.com/aws/aws-sdk-go-v2/service/sso v1.22.5 // indirect
73-
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5 // indirect
69+
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.19 // indirect
70+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.19 // indirect
71+
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.17 // indirect
72+
github.com/aws/aws-sdk-go-v2/service/sso v1.22.7 // indirect
73+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.7 // indirect
7474
github.com/aws/smithy-go v1.20.4 // indirect
7575
github.com/beorn7/perks v1.0.1 // indirect
7676
github.com/cespare/xxhash/v2 v2.3.0 // indirect
@@ -83,7 +83,7 @@ require (
8383
github.com/golang/protobuf v1.5.4 // indirect
8484
github.com/google/go-cmp v0.6.0 // indirect
8585
github.com/google/s2a-go v0.1.8 // indirect
86-
github.com/googleapis/enterprise-certificate-proxy v0.3.3 // indirect
86+
github.com/googleapis/enterprise-certificate-proxy v0.3.4 // indirect
8787
github.com/googleapis/gax-go/v2 v2.13.0 // indirect
8888
github.com/grpc-ecosystem/grpc-gateway/v2 v2.22.0 // indirect
8989
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
@@ -92,14 +92,14 @@ require (
9292
go.opencensus.io v0.24.0 // indirect
9393
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.54.0 // indirect
9494
go.opentelemetry.io/otel/metric v1.29.0 // indirect
95-
golang.org/x/crypto v0.26.0 // indirect
96-
golang.org/x/mod v0.20.0 // indirect
97-
golang.org/x/net v0.28.0 // indirect
98-
golang.org/x/text v0.17.0 // indirect
95+
golang.org/x/crypto v0.27.0 // indirect
96+
golang.org/x/mod v0.21.0 // indirect
97+
golang.org/x/net v0.29.0 // indirect
98+
golang.org/x/text v0.18.0 // indirect
9999
golang.org/x/time v0.6.0 // indirect
100-
golang.org/x/tools v0.24.0 // indirect
101-
google.golang.org/genproto v0.0.0-20240827150818-7e3bb234dfed // indirect
102-
google.golang.org/genproto/googleapis/api v0.0.0-20240827150818-7e3bb234dfed // indirect
100+
golang.org/x/tools v0.25.0 // indirect
101+
google.golang.org/genproto v0.0.0-20240903143218-8af14fe29dc1 // indirect
102+
google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 // indirect
103103
gopkg.in/yaml.v3 v3.0.1 // indirect
104104
sigs.k8s.io/yaml v1.4.0 // indirect
105105
)

0 commit comments

Comments
 (0)