Merge pull request #15 from buildkite/pie-1484-remove-identifier-from-elixir-test

PIE-1484 Remove identifier from Elixir test collector payloads

Author: amybiyuliu

lib/buildkite_test_collector/test_result.ex

@@ -18,7 +18,6 @@ defmodule BuildkiteTestCollector.TestResult do
     :id,
     :scope,
     :name,
-    :identifier,
     :location,
     :file_name,
     :result,
@@ -32,7 +31,6 @@ defmodule BuildkiteTestCollector.TestResult do
           id: UUID.t(),
           scope: String.t(),
           name: String.t(),
-          identifier: String.t(),
           file_name: String.t(),
           result: String.t(),
           failure_reason: nil | String.t(),
@@ -77,7 +75,6 @@ defmodule BuildkiteTestCollector.TestResult do
       id: UUID.generate(),
       scope: extract_test_scope(test),
       name: extract_test_name(test),
-      identifier: location,
       location: location,
       file_name: test.tags.file,
       result: extract_test_result(test.state),
@@ -112,7 +109,6 @@ defmodule BuildkiteTestCollector.TestResult do
       id: test_result.id,
       scope: test_result.scope,
       name: test_result.name,
-      identifier: test_result.identifier,
       location: test_result.location,
       file_name: test_result.file_name,
       result: test_result.result,

test/buildkite_test_collector/test_result_test.exs

@@ -13,6 +13,9 @@ defmodule BuildkiteTestCollector.TestResultTest do
 
       assert result.result == "passed"
       assert result.scope == "PassingTest"
+      assert result.location == "test/support/fixture_tests/passing_test.exs:5"
+      assert result.file_name == "test/support/fixture_tests/passing_test.exs"
+      assert result.name == "PassingTest test passing"
       refute result.failure_reason
       refute result.failure_expanded
     end