Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3v6 update #4

Open
ValentinaChaconBuitrago opened this issue May 18, 2021 · 6 comments
Open

d3v6 update #4

ValentinaChaconBuitrago opened this issue May 18, 2021 · 6 comments

Comments

@ValentinaChaconBuitrago
Copy link

ValentinaChaconBuitrago commented May 18, 2021

Thanks for this great solution! In observable barRangeSlider with d3v5 works fine but it stops working when using d3v6. Am I importing d3 wrong or does the barRangeSlider include deprecated code (I'm sorry, I'm new to this and am a little confused)?

@bumbeishvili
Copy link
Owner

It's d3 v5 based and won't work with d3v6

@creynolds-icr
Copy link

Hi @bumbeishvili we're leveraging this nice little plugin for some of our map views. I ran into the d3 v6+ issue also and made a few lines of changes to the .on() calls in brush to make it compatible with newer d3. If you're interested, I'm happy to open a pull request for that and the package.json update. Otherwise I can just comment here for anybody else who stumbles onto this. Thanks!

@bumbeishvili
Copy link
Owner

Nice, please feel free to open a pull request and link it as well, in case anyone interested how to port it to v6 (or v7)

@creynolds-icr
Copy link

Are you able to grant me write permissions to this repo so I can push a branch? Or is the pref to create a new fork and perform the pull request from there?

@bumbeishvili
Copy link
Owner

Yes, pull request from forked repo is preferable

@bumbeishvili
Copy link
Owner

PR for mentioned changes - #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants