Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeConnector intake is not disposed when a node is destroyed #296

Open
LachlanMcKee opened this issue Dec 4, 2022 · 0 comments · May be fixed by #297
Open

NodeConnector intake is not disposed when a node is destroyed #296

LachlanMcKee opened this issue Dec 4, 2022 · 0 comments · May be fixed by #297
Assignees
@LachlanMcKee
Labels
bug Something isn't working

Comments

@LachlanMcKee
Copy link
Collaborator

It seems that not disposing NodeConnector.intake when a Node is destroyed is a bug.

Please let me know if this is intended. It could also potentially be a breaking change, so perhaps we need to throw an error if it happens
@LachlanMcKee LachlanMcKee added the bug Something isn't working label Dec 4, 2022
@LachlanMcKee LachlanMcKee self-assigned this Dec 4, 2022
LachlanMcKee added a commit to LachlanMcKee/appyx that referenced this issue Dec 4, 2022
@LachlanMcKee
Issue bumble-tech#296 Dispose NodeConnector intake in onDestroy
d4da1b5
@LachlanMcKee LachlanMcKee linked a pull request Dec 4, 2022 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LachlanMcKee LachlanMcKee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #296 Dispose NodeConnector intake in onDestroy LachlanMcKee/appyx
1 participant
@LachlanMcKee