Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] K8S Hardcoded cluster dns suffix #1631

Open
2 tasks done
schmittse opened this issue Oct 28, 2024 · 2 comments
Open
2 tasks done

[BUG] K8S Hardcoded cluster dns suffix #1631

schmittse opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@schmittse
Copy link

What happened?

In IngressController.py the suffix cluster.local is hardcoded (line 115).
This value can be customized in a k8s cluster install so it should be editable using configuration.

How to reproduce?

Install a cluster with a custom domain suffix, any Ingress will leads to a backend not found error.

Configuration file(s) (yaml or .env)

N/A

Relevant log output

N/A

BunkerWeb version

1.5.10

What integration are you using?

Kubernetes

Linux distribution (if applicable)

Ubuntu Server 20.04

Removed private data

  • I have removed all private data from the configuration file and the logs

Code of Conduct

  • I agree to follow this project's Code of Conduct
@schmittse schmittse added the bug Something isn't working label Oct 28, 2024
@fl0ppy-d1sk
Copy link
Member

Hello @schmittse,

Thanks for your feedback. It will be implemented in the upcoming 1.6.0 release.

Will keep you updated once it's available in 1.6.0-beta if you have time to test it.

@schmittse
Copy link
Author

Hi,

Thanks for the feedback, I'll give 1.6.0-beta a try.
I've also started o work on some fixes of my own, i'll try to contribute.

Already noted on the 1.6.0 code, you are missing watching on ingressclass changes as multiple classes can be added after bunkerWeb install. And the "default" class has to be handled as well.

And trying to fix issue #585 on this beta branch will be a huge bonus for k8s admins.
With this, bunkerweb could be a drop-in replacement for nginxIngressController :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants