feature/sdk_python#149 Clean up.

Author: angelomelonas

Diff for: bunq/sdk/util/util.py

@@ -8,7 +8,6 @@
 from bunq.sdk.context.api_context import ApiContext, ApiEnvironmentType
 from bunq.sdk.exception.bunq_exception import BunqException
 from bunq.sdk.http.api_client import ApiClient
-from bunq.sdk.model.generated import endpoint
 from bunq.sdk.model.generated.endpoint import SandboxUserPerson
 
 __UNIQUE_REQUEST_ID = "uniqueness-is-required"
@@ -17,16 +16,15 @@
 __FIELD_RESPONSE = "Response"
 __ENDPOINT_SANDBOX_USER_PERSON = "sandbox-user-person"
 
+# Error constants
 _ERROR_COULD_NOT_CREATE_NEW_SANDBOX_USER = "Could not create new sandbox user."
+_ERROR_ALL_FIELD_IS_NULL = 'All fields are null'
 
 
 def automatic_sandbox_install() -> ApiContext:
     sandbox_user = __generate_new_sandbox_user()
 
-    return ApiContext.create(ApiEnvironmentType.SANDBOX,
-                             sandbox_user.api_key,
-                             socket.gethostname()
-                             )
+    return ApiContext.create(ApiEnvironmentType.SANDBOX, sandbox_user.api_key, socket.gethostname())
 
 
 def __generate_new_sandbox_user() -> SandboxUserPerson:
@@ -44,8 +42,7 @@ def __generate_new_sandbox_user() -> SandboxUserPerson:
 
     if response.status_code is ApiClient.STATUS_CODE_OK:
         response_json = json.loads(response.text)
-        return SandboxUserPerson.from_json(
-            json.dumps(response_json[__FIELD_RESPONSE][__INDEX_FIRST][
-                           __FIELD_API_KEY]))
+
+        return SandboxUserPerson.from_json(json.dumps(response_json[__FIELD_RESPONSE][__INDEX_FIRST][__FIELD_API_KEY]))
 
     raise BunqException(_ERROR_COULD_NOT_CREATE_NEW_SANDBOX_USER)

Diff for: tests/context/test_api_context.py

@@ -23,11 +23,10 @@ class TestApiContext(BunqSdkTestCase):
     def setUpClass(cls) -> None:
         super().setUpClass()
         cls._FILE_MODE_READ = ApiContext._FILE_MODE_READ
-        cls._API_CONTEXT = cls._get_api_context()
-        cls._TMP_FILE_PATH_FULL = (cls._get_directory_test_root() +
-                                   cls._TMP_FILE_PATH)
+        cls._API_CONTEXT: ApiContext = cls._get_api_context()
+        cls._TMP_FILE_PATH_FULL = (cls._get_directory_test_root() + cls._TMP_FILE_PATH)
 
-    def test_api_context_save(self):
+    def test_api_context_save(self) -> None:
         """
         Converts an ApiContext to JSON data, saves the same ApiContext to a
         temporary file, and compares whether the JSON data is equal to the
@@ -47,7 +46,7 @@ def test_api_context_save(self):
 
         self.assertEqual(context_retrieved, context_json)
 
-    def test_api_context_restore(self):
+    def test_api_context_restore(self) -> None:
         """
         Saves an ApiContext to a temporary file, restores an ApiContext from
         that file, and compares whether the api_keys, tokens, and environment