Merge branch 'fix/feeabs-codec' of github.com:burnt-labs/xion into fix/feeabs-codec

Author: 2xburnt

x/jwk/client/cli/cli_test.go

@@ -7,11 +7,11 @@ import (
 	"strings"
 	"testing"
 
-	rpcclientmock "github.com/cometbft/cometbft/rpc/client/mock"
-
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/require"
 
+	rpcclientmock "github.com/cometbft/cometbft/rpc/client/mock"
+
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
@@ -125,12 +125,14 @@ func TestConvertPemToJSONCases(t *testing.T) {
 	// Invalid content
 	tmpInvalid, _ := os.CreateTemp("", "bad*.pem")
 	defer os.Remove(tmpInvalid.Name())
-	tmpInvalid.WriteString("not a pem")
+	_, err = tmpInvalid.WriteString("not a pem")
+	require.NoError(t, err)
 	tmpInvalid.Close()
 	_, err = clitestutil.ExecTestCLICmd(ctx, cli.CmdConvertPemToJSON(), []string{tmpInvalid.Name()})
 	require.Error(t, err)
 
 	// Valid PEM (RSA public key) one & algorithm branch
+	// nolint: goconst
 	validPEM := `-----BEGIN PUBLIC KEY-----
 MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAjR+4XbCgepL6/I7KLqUJ
 m3sUNwcCCLJDMiIZbHS3duf7oYdOtVeAykP4ga6cmJZZE+1+TiiXZArXwOx6fO1N
@@ -142,7 +144,8 @@ AwIDAQAB
 -----END PUBLIC KEY-----`
 	tmpValid, _ := os.CreateTemp("", "valid*.pem")
 	defer os.Remove(tmpValid.Name())
-	tmpValid.WriteString(validPEM)
+	_, err = tmpValid.WriteString(validPEM)
+	require.NoError(t, err)
 	tmpValid.Close()
 
 	out, err := clitestutil.ExecTestCLICmd(ctx, cli.CmdConvertPemToJSON(), []string{tmpValid.Name()})
@@ -303,7 +306,8 @@ iTo7Tu6KPAqv7D7gS2XpJFbZiItSs3m9+9Ue6GnvHw/GW2ZZaVtszggXIw==
 -----END PUBLIC KEY-----`
 	tmpEC, _ := os.CreateTemp("", "ec*.pem")
 	defer os.Remove(tmpEC.Name())
-	tmpEC.WriteString(ecPEM)
+	_, err := tmpEC.WriteString(ecPEM)
+	require.NoError(t, err)
 	tmpEC.Close()
 
 	out, err := clitestutil.ExecTestCLICmd(ctx, cli.CmdConvertPemToJSON(), []string{tmpEC.Name()})
@@ -432,7 +436,8 @@ AwIDAQAB
 -----END PUBLIC KEY-----`
 	tmpValid, _ := os.CreateTemp("", "test*.pem")
 	defer os.Remove(tmpValid.Name())
-	tmpValid.WriteString(validPEM)
+	_, err := tmpValid.WriteString(validPEM)
+	require.NoError(t, err)
 	tmpValid.Close()
 
 	// With empty context, may succeed with parsing but fail on output
@@ -508,16 +513,20 @@ func TestUpdateAudienceAdditionalPaths(t *testing.T) {
 
 	// Test with flags - should use default admin when new-admin is empty
 	args := []string{"aud", "key"}
-	cmd.Flags().Set("new-admin", "") // Empty admin should use default
-	cmd.Flags().Set("new-aud", "new-aud")
+	err := cmd.Flags().Set("new-admin", "") // Empty admin should use default
+	require.NoError(t, err)
+	err = cmd.Flags().Set("new-aud", "new-aud")
+	require.NoError(t, err)
 	// This should fail because the mock context doesn't provide a valid from address
-	_, err := clitestutil.ExecTestCLICmd(ctx, cmd, args)
+	_, err = clitestutil.ExecTestCLICmd(ctx, cmd, args)
 	require.Error(t, err) // Expecting error due to invalid address
 
 	// Test with explicit new-admin
 	cmd2 := cli.CmdUpdateAudience()
-	cmd2.Flags().Set("new-admin", "cosmos1testadmin")
-	cmd2.Flags().Set("new-aud", "new-aud")
+	err = cmd2.Flags().Set("new-admin", "cosmos1testadmin")
+	require.NoError(t, err)
+	err = cmd2.Flags().Set("new-aud", "new-aud")
+	require.NoError(t, err)
 	_, err = clitestutil.ExecTestCLICmd(ctx, cmd2, args)
 	require.Error(t, err) // Still expecting error due to invalid bech32 format
 }
@@ -544,8 +553,9 @@ func TestQueryCommandsFullCoverage(t *testing.T) {
 	listCmd := cli.CmdListAudience()
 
 	// Test with page-key
-	listCmd.Flags().Set("page-key", "test-key")
-	_, err := clitestutil.ExecTestCLICmd(ctx, listCmd, []string{})
+	err := listCmd.Flags().Set("page-key", "test-key")
+	require.NoError(t, err)
+	_, err = clitestutil.ExecTestCLICmd(ctx, listCmd, []string{})
 	require.NoError(t, err)
 
 	// Test params command
@@ -579,10 +589,12 @@ func TestListAudiencePaginationError(t *testing.T) {
 
 	// Set invalid pagination values that should cause ReadPageRequest to fail
 	// Use both page and page-key which should be mutually exclusive
-	cmd.Flags().Set("page", "1")
-	cmd.Flags().Set("page-key", "somekey")
+	err := cmd.Flags().Set("page", "1")
+	require.NoError(t, err)
+	err = cmd.Flags().Set("page-key", "somekey")
+	require.NoError(t, err)
 
-	_, err := clitestutil.ExecTestCLICmd(ctx, cmd, []string{})
+	_, err = clitestutil.ExecTestCLICmd(ctx, cmd, []string{})
 	// The pagination test may not fail with negative limit, so let's check any pagination error
 	if err != nil {
 		// Good, we got an error from pagination validation
@@ -625,8 +637,10 @@ func TestTxContextErrors(t *testing.T) {
 
 	// Test CmdUpdateAudience with empty context
 	updateCmd := cli.CmdUpdateAudience()
-	updateCmd.Flags().Set("new-admin", "cosmos1test")
-	updateCmd.Flags().Set("new-aud", "new-aud")
+	err = updateCmd.Flags().Set("new-admin", "cosmos1test")
+	require.NoError(t, err)
+	err = updateCmd.Flags().Set("new-aud", "new-aud")
+	require.NoError(t, err)
 	_, err = clitestutil.ExecTestCLICmd(emptyCtx, updateCmd, []string{"aud", "key"})
 	require.Error(t, err) // Should fail with tx context error