clean up formatting

Author: 2xburnt

x/feeabs/types/codec_test.go

@@ -3,10 +3,11 @@ package types
 import (
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/cosmos/cosmos-sdk/codec"
 	"github.com/cosmos/cosmos-sdk/codec/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/stretchr/testify/require"
 )
 
 func TestRegisterCodec(t *testing.T) {

x/feeabs/types/errors_test.go

@@ -3,8 +3,9 @@ package types
 import (
 	"testing"
 
-	sdkerrors "cosmossdk.io/errors"
 	"github.com/stretchr/testify/require"
+
+	sdkerrors "cosmossdk.io/errors"
 )
 
 func TestErrors(t *testing.T) {

x/feeabs/types/ibc_test.go

@@ -4,8 +4,9 @@ import (
 	"testing"
 	"time"
 
-	abci "github.com/cometbft/cometbft/abci/types"
 	"github.com/stretchr/testify/require"
+
+	abci "github.com/cometbft/cometbft/abci/types"
 )
 
 func TestIBCConstants(t *testing.T) {

x/feeabs/types/msg_test.go

@@ -3,9 +3,11 @@ package types
 import (
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
 	"cosmossdk.io/math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/stretchr/testify/require"
 )
 
 func TestMsgSendQueryIbcDenomTWAP(t *testing.T) {

x/feeabs/types/params.go

@@ -63,7 +63,6 @@ func (p Params) Validate() error {
 		return err
 	}
 
-
 	return nil
 }
 

x/feeabs/types/params_test.go

@@ -4,9 +4,10 @@ import (
 	"fmt"
 	"testing"
 
-	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
 )
 
 func Test_ParamString(t *testing.T) {
@@ -580,4 +581,3 @@ func TestParamsValidateViaParamSetPairs(t *testing.T) {
 		}
 	})
 }
-

x/feeabs/types/proposal_test.go

@@ -3,8 +3,9 @@ package types
 import (
 	"testing"
 
-	v1beta1types "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
 	"github.com/stretchr/testify/require"
+
+	v1beta1types "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
 )
 
 func TestProposalConstants(t *testing.T) {

x/globalfee/ante/fee_test.go

@@ -21,6 +21,10 @@ import (
 	"github.com/burnt-labs/xion/x/globalfee/types"
 )
 
+const (
+	testStakingDenom = "stake"
+)
+
 func TestNewFeeDecorator(t *testing.T) {
 	// Create a test subspace without key table
 	storeKey := storetypes.NewKVStoreKey(paramstypes.StoreKey)
@@ -34,9 +38,7 @@ func TestNewFeeDecorator(t *testing.T) {
 		types.ModuleName,
 	)
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	// Test with subspace that doesn't have key table - should panic
 	require.Panics(t, func() {
@@ -71,9 +73,7 @@ func TestFeeDecoratorMethods(t *testing.T) {
 	}
 	subspace.SetParamSet(ctx.Ctx, &params)
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	decorator := ante.NewFeeDecorator(subspace, stakingDenomFunc)
 
@@ -89,7 +89,7 @@ func TestFeeDecoratorMethods(t *testing.T) {
 	require.NoError(t, err)
 	require.NotNil(t, zeroFees)
 	require.Len(t, zeroFees, 1)
-	require.Equal(t, "stake", zeroFees[0].Denom)
+	require.Equal(t, testStakingDenom, zeroFees[0].Denom)
 	require.True(t, zeroFees[0].Amount.IsZero())
 
 	// Test ContainsOnlyBypassMinFeeMsgs
@@ -147,9 +147,7 @@ func TestGetGlobalFeeEmptyParams(t *testing.T) {
 	}
 	subspace.SetParamSet(ctx.Ctx, &params)
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	decorator := ante.NewFeeDecorator(subspace, stakingDenomFunc)
 
@@ -158,7 +156,7 @@ func TestGetGlobalFeeEmptyParams(t *testing.T) {
 	require.NoError(t, err)
 	require.NotNil(t, globalFees)
 	require.Len(t, globalFees, 1)
-	require.Equal(t, "stake", globalFees[0].Denom)
+	require.Equal(t, testStakingDenom, globalFees[0].Denom)
 	require.True(t, globalFees[0].Amount.IsZero())
 }
 
@@ -216,9 +214,7 @@ func TestContainsOnlyBypassMinFeeMsgsEdgeCases(t *testing.T) {
 		types.ModuleName,
 	).WithKeyTable(types.ParamKeyTable())
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	decorator := ante.NewFeeDecorator(subspace, stakingDenomFunc)
 
@@ -310,9 +306,7 @@ func TestContainsOnlyBypassMinFeeMsgsWithMessages(t *testing.T) {
 		types.ModuleName,
 	).WithKeyTable(types.ParamKeyTable())
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	decorator := ante.NewFeeDecorator(subspace, stakingDenomFunc)
 
@@ -450,9 +444,7 @@ func TestAnteHandle(t *testing.T) {
 	params := types.DefaultParams()
 	subspace.SetParamSet(ctx.Ctx, &params)
 
-	stakingDenomFunc := func(ctx sdk.Context) string {
-		return "stake"
-	}
+	stakingDenomFunc := func(ctx sdk.Context) string { return testStakingDenom }
 
 	decorator := ante.NewFeeDecorator(subspace, stakingDenomFunc)
 

x/globalfee/client/cli/query_test.go

@@ -4,9 +4,10 @@ import (
 	"context"
 	"testing"
 
-	rpcclientmock "github.com/cometbft/cometbft/rpc/client/mock"
 	"github.com/stretchr/testify/require"
 
+	rpcclientmock "github.com/cometbft/cometbft/rpc/client/mock"
+
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
@@ -192,7 +193,8 @@ func TestGetCmdShowGlobalFeeParamsRunEErrorPath(t *testing.T) {
 
 	// Test RunE with no client context (should panic, which we recover)
 	require.Panics(t, func() {
-		cmd.RunE(cmd, []string{})
+		// capture error value explicitly to satisfy errcheck while still triggering panic path
+		_ = cmd.RunE(cmd, []string{})
 	}, "Expected panic when no client context is set")
 }
 

x/globalfee/module.go

@@ -34,6 +34,9 @@ var (
 // AppModuleBasic defines the basic application module used by the wasm module.
 type AppModuleBasic struct{}
 
+// reused literal to avoid triggering goconst / allow inline explanatory comments
+const noOp = "no-op"
+
 func (a AppModuleBasic) Name() string {
 	return types.ModuleName
 }
@@ -58,12 +61,12 @@ func (a AppModuleBasic) ValidateGenesis(marshaler codec.JSONCodec, _ client.TxEn
 
 func (a AppModuleBasic) RegisterInterfaces(_ codectypes.InterfaceRegistry) {
 	// No interfaces to register for globalfee module
-	_ = "no-op"
+	_ = noOp
 }
 
 func (a AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {
 	// No REST routes to register for globalfee module
-	_ = "no-op"
+	_ = noOp
 }
 
 // RegisterQueryHandlerClientFn is an overrideable hook (exported for tests) used to register
@@ -89,7 +92,7 @@ func (a AppModuleBasic) GetQueryCmd() *cobra.Command {
 
 func (a AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {
 	// No legacy amino codec registration needed for globalfee module
-	_ = "no-op"
+	_ = noOp
 }
 
 type AppModule struct {
@@ -99,12 +102,12 @@ type AppModule struct {
 
 func (a AppModule) IsOnePerModuleType() {
 	// Interface marker method - indicates this module should only be instantiated once per chain
-	_ = "no-op"
+	_ = noOp
 }
 
 func (a AppModule) IsAppModule() {
 	// Interface marker method - indicates this implements the AppModule interface
-	_ = "no-op"
+	_ = noOp
 }
 
 // NewAppModule constructor
@@ -131,7 +134,8 @@ func (a AppModule) ExportGenesis(ctx sdk.Context, marshaler codec.JSONCodec) jso
 }
 
 func (a AppModule) RegisterServices(cfg module.Configurator) {
-	types.RegisterQueryServer(cfg.QueryServer(), NewGrpcQuerier(a.globalfeeSubspace))
+	// inline creation of GrpcQuerier to avoid potential build tag / symbol resolution issues during linting
+	types.RegisterQueryServer(cfg.QueryServer(), GrpcQuerier{paramSource: a.globalfeeSubspace})
 
 	m := keeper.NewMigrator(a.globalfeeSubspace)
 	if err := cfg.RegisterMigration(types.ModuleName, 1, m.Migrate1to2); err != nil {