Skip to content

Commit d7130e5

Browse files
authored
fix upgrade name (#371)
This pull request includes minor updates related to versioning, code cleanup, and the stargate whitelist configuration. The main changes involve updating the upgrade version, removing commented-out code and unused imports, and cleaning up the initialization of the stargate whitelist. Versioning update: * Changed the upgrade name constant from `"v20"` to `"v21"` in `app/upgrades.go` to reflect the new upgrade version. Code cleanup: * Removed commented-out import statements for unused IBC transfer types in `wasmbindings/stargate_whitelist.go`. * Removed commented-out code and a TODO related to IBC queries from the initialization of the stargate whitelist in `wasmbindings/stargate_whitelist.go`. * Removed an outdated TODO comment about replacing IBC hooks with callbacks in `app/app.go`.
1 parent f0bb5a5 commit d7130e5

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

app/app.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,6 @@ func NewWasmApp(
604604
authtypes.NewModuleAddress(govtypes.ModuleName).String(),
605605
)
606606

607-
// TODO: Replace ibc hooks with callbacks?
608607
// Configure the hooks keeper
609608
// hooksKeeper := ibchookskeeper.NewKeeper(
610609
// keys[ibchookstypes.StoreKey],

app/upgrades.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
"github.com/cosmos/cosmos-sdk/types/module"
1313
)
1414

15-
const UpgradeName = "v20"
15+
const UpgradeName = "v21"
1616

1717
func (app *WasmApp) RegisterUpgradeHandlers() {
1818
upgradeInfo, err := app.UpgradeKeeper.ReadUpgradeInfoFromDisk()

wasmbindings/stargate_whitelist.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import (
77
wasmvmtypes "github.com/CosmWasm/wasmvm/v3/types"
88

99
"github.com/cosmos/gogoproto/proto"
10-
// nolint: gci
11-
// ibctransfertypes "github.com/cosmos/ibc-go/v10/modules/apps/transfer/types"
1210

1311
feegranttypes "cosmossdk.io/x/feegrant"
1412

@@ -37,10 +35,6 @@ var stargateWhitelist sync.Map
3735
// In the future we may want to find a better way to keep these in sync
3836

3937
func init() {
40-
// ibc queries
41-
// TODO: fix
42-
// setWhitelistedQuery("/ibc.applications.transfer.v1.Query/DenomTrace", &ibctransfertypes.QueryDenomTraceResponse{})
43-
4438
// cosmos-sdk queries
4539

4640
// auth

0 commit comments

Comments
 (0)