Release/v20 (#348)

This pull request introduces several changes across workflows,
configuration files, and the application codebase. The most significant
updates include the removal of the fee abstraction module, the addition
of the circuit breaker module, updates to workflows for improved
dependency management, and enhancements to the integration testing
framework.

### Workflow and Configuration Updates:
*
[`.github/workflows/create-release.yaml`](diffhunk://#diff-a318819fb0ec8889018cbef8e6dd222e317757d95ddd93b62b714ac7c49f04f6L91-L115):
Removed unused jobs (`build-release-info` and `update-networks`) to
streamline the release workflow.
*
[`.github/workflows/golangci-lint.yaml`](diffhunk://#diff-663d31008ec91b12d46959a84b8604f87c6be56c98db4dc4278411da292115f0L27-R29):
Updated the `golangci-lint` action to version `v8` and increased the
linter version to `v2.2.1` for better linting capabilities.
*
[`.golangci.yml`](diffhunk://#diff-6179837f7df53a6f05c522b6b7bb566d484d5465d9894fb04910dd08bb40dcc9R1-R72):
Refactored the configuration to enable additional linters, reorganize
settings, and add exclusions for generated files and common false
positives.

### Application Codebase Changes:
#### Fee Abstraction Removal:
* `app/ante.go`, `app/app.go`: Removed all references to the fee
abstraction module (`feeabs`) and its associated decorators, keepers,
and configurations.
[[1]](diffhunk://#diff-5c8651424dbfaa86b2894ea499273a1b26c4e0abf0d534b6b9e103b0822cb2b1L8-R15)
[[2]](diffhunk://#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7L21-L23)
[[3]](diffhunk://#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7L363-R369)

#### Circuit Breaker Addition:
* `app/ante.go`, `app/app.go`: Introduced the circuit breaker module
(`circuit`) with its keeper and decorators for enhanced transaction
safety. Integrated it into the ante handler and app initialization.
[[1]](diffhunk://#diff-5c8651424dbfaa86b2894ea499273a1b26c4e0abf0d534b6b9e103b0822cb2b1L63-R71)
[[2]](diffhunk://#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R510-R517)

### Integration Testing Enhancements:
* `.github/workflows/integration-tests.yaml`, `Makefile`: Added new test
cases for multi-denomination minimum global fees
(`MultiDenomMinGlobalFee` and `MultiDenomMinGlobalFeeIBC`) to expand
test coverage.
[[1]](diffhunk://#diff-213e9bbc551ccc9ca3cbb6b69999a415116e2ee37ccc88e34a98c5dd27bbc31aR29-R30)
[[2]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R246-R251)

### Release Configuration:
*
[`.goreleaser/release.yaml`](diffhunk://#diff-c601da1e14a8650711871101995d0d5706a1e463b8d72f076f7bea5817b6c661L57-R58):
Moved checksum generation under `nfpms` and added conditional logic to
exclude snapshots from certain operations.
[[1]](diffhunk://#diff-c601da1e14a8650711871101995d0d5706a1e463b8d72f076f7bea5817b6c661L57-R58)
[[2]](diffhunk://#diff-c601da1e14a8650711871101995d0d5706a1e463b8d72f076f7bea5817b6c661R73-R77)
[[3]](diffhunk://#diff-c601da1e14a8650711871101995d0d5706a1e463b8d72f076f7bea5817b6c661R87)

---------

Signed-off-by: Justin <[email protected]>
Signed-off-by: TwiceBurnt <[email protected]>
Co-authored-by: Eduardo Díaz <[email protected]>
Co-authored-by: Kehinde Faleye <[email protected]>
Co-authored-by: Ash <[email protected]>
Co-authored-by: Eduardo Diaz <[email protected]>
Co-authored-by: Justin <[email protected]>
Co-authored-by: Ash <[email protected]>

Author: 5 people

.github/workflows/create-release.yaml

@@ -88,31 +88,13 @@ jobs:
     uses: burnt-labs/xion/.github/workflows/goreleaser.yaml@workflows/main
     secrets: inherit
 
-  # # TODO: move to goreleaser
-  # build-release-info:
-  #   name: Build Release Info
-  #   needs:
-  #     - build-darwin
-  #     - build-linux
-  #   uses: burnt-labs/xion/.github/workflows/build-release-info.yaml@workflows/main
-  #   secrets: inherit
-
   # TODO: move to goreleaser
   publish-types:
     name: Publish Typescript Types
     needs: build-release
     uses: burnt-labs/xion/.github/workflows/publish-types.yaml@workflows/main
     secrets: inherit
 
-  # TODO: move to triggered action in burnt-networks repo
-  # update-networks:
-  #   name: Update Networks Repo
-  #   needs:
-  #     - build-release
-  #     - build-release-info
-  #   uses: burnt-labs/xion/.github/workflows/update-networks.yaml@workflows/main
-  #   secrets: inherit
-
   verify-installers:
     name: Verify Package Installers
     needs: build-release

.github/workflows/golangci-lint.yaml

@@ -24,7 +24,7 @@ jobs:
           go-version: ${{ env.GO_VERSION }}
 
       - name: golangci-lint-xiond
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.64.8
+          version: v2.2.1
           args: --timeout=10m --tests=false

.github/workflows/integration-tests.yaml

@@ -26,6 +26,8 @@ jobs:
             - "MintModuleInflationLowFees"
             - "MintModuleInflationNoFees"
             - "MintModuleNoInflationNoFees"
+            - "MultiDenomMinGlobalFee"
+            - "MultiDenomMinGlobalFeeIBC"
             - "Simulate"
             - "SingleAbstractAccountMigration"
             - "TreasuryContract"

.golangci.yml

@@ -1,54 +1,72 @@
+version: "2"
 run:
-  # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 10m
   tests: true
-
 linters:
-  disable-all: true
+  default: none
   enable:
     - bodyclose
+    - copyloopvar
     - dogsled
     - errcheck
     - goconst
     - gocritic
-    - gofumpt
-    - gci
-    - revive
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
     - nakedret
-    - copyloopvar
+    - revive
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
-    - unused
     - unparam
-    - misspell
-
-linters-settings:
-  gci:
-    custom-order: true
-    sections:
-      - standard # Standard section: captures all standard packages.
-      - default # Default section: contains all imports that could not be matched to another section type.
-      - blank # blank imports
-      - dot # dot imports
-      - prefix(github.com/cometbft/cometbft)
-      - prefix(github.com/cosmos)
-      - prefix(cosmossdk.io)
-      - prefix(github.com/cosmos/cosmos-sdk)
-      - prefix(github.com/burnt-labs/xion)
-  gosec:
-    excludes:
-      - G404
-  gocritic:
-    disabled-checks:
-      - appendAssign
-
+    - unused
+  settings:
+    gocritic:
+      disabled-checks:
+        - appendAssign
+    gosec:
+      excludes:
+        - G404
+    revive:
+      rules:
+      - name: "var-naming"
+        disabled: true
+        severity: "warning"
+        arguments: []
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
+formatters:
+  enable:
+    - gci
+    - gofumpt
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - blank
+        - dot
+        - prefix(github.com/cometbft/cometbft)
+        - prefix(github.com/cosmos)
+        - prefix(cosmossdk.io)
+        - prefix(github.com/cosmos/cosmos-sdk)
+        - prefix(github.com/burnt-labs/xion)
+      custom-order: true
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

.goreleaser/release.yaml

@@ -54,13 +54,8 @@ archives:
     wrap_in_directory: false
     strip_binary_directory: false
 
-# docs: https://goreleaser.com/customization/checksum/
-checksum:
-  name_template: "xiond-{{ .Version }}-checksums.txt"
-  algorithm: sha256
-
 nfpms:
-  - if: '{{ eq .Os "linux" }}'
+  - if: '{{ and (eq .Os "linux") (not .IsSnapshot) }}'
     formats:
       - apk
       - deb
@@ -75,6 +70,11 @@ nfpms:
       signature:
         key_file: "{{ .Env.GPG_KEY_PATH }}"
 
+# docs: https://goreleaser.com/customization/checksum/
+checksum:
+  name_template: "xiond-{{ .Version }}-checksums.txt"
+  algorithm: sha256
+
 # not used
 # signs:
 #   - artifacts: package
@@ -84,6 +84,7 @@ nfpms:
 # docs https://goreleaser.com/customization/fury/
 furies:
   - account: burnt
+    disable: "{{ .IsSnapshot }}"
 
 # Docs: https://goreleaser.com/customization/homebrew/
 brews:

Makefile

@@ -243,6 +243,12 @@ test-integration-xion-abstract-account-event: compile_integration_tests
 test-integration-xion-min-default: compile-integration-tests
 	$(MAKE) run-integration-test TEST_NAME=TestXionMinimumFeeDefault
 
+test-integration-xion-min-multi-denom: compile-integration-tests
+	$(MAKE) run-integration-test TEST_NAME=TestMultiDenomMinGlobalFee
+
+test-integration-xion-min-multi-denom-ibc: compile-integration-tests
+	$(MAKE) run-integration-test TEST_NAME=TestMultiDenomMinGlobalFeeIBC
+
 test-integration-xion-min-zero: compile-integration-tests
 	$(MAKE) run-integration-test TEST_NAME=TestXionMinimumFeeZero
 

app/ante.go

@@ -5,14 +5,14 @@ import (
 	wasmTypes "github.com/CosmWasm/wasmd/x/wasm/types"
 	"github.com/larry0x/abstract-account/x/abstractaccount"
 	aakeeper "github.com/larry0x/abstract-account/x/abstractaccount/keeper"
-	feeabsante "github.com/osmosis-labs/fee-abstraction/v8/x/feeabs/ante"
-	feeabskeeper "github.com/osmosis-labs/fee-abstraction/v8/x/feeabs/keeper"
 
 	ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante"
 	"github.com/cosmos/ibc-go/v8/modules/core/keeper"
 
 	corestoretypes "cosmossdk.io/core/store"
 	errorsmod "cosmossdk.io/errors"
+	circuitante "cosmossdk.io/x/circuit/ante"
+	circuitkeeper "cosmossdk.io/x/circuit/keeper"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
@@ -35,7 +35,7 @@ type HandlerOptions struct {
 	GlobalFeeSubspace     paramtypes.Subspace
 	StakingKeeper         *stakingkeeper.Keeper
 	AbstractAccountKeeper aakeeper.Keeper
-	FeeAbsKeeper          *feeabskeeper.Keeper
+	CircuitKeeper         *circuitkeeper.Keeper
 }
 
 func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {
@@ -60,14 +60,15 @@ func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {
 	if options.TXCounterStoreService == nil {
 		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "wasm store service is required for ante builder")
 	}
-	if options.FeeAbsKeeper == nil {
-		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "fee abstraction keeper is required for AnteHandler")
+	if options.CircuitKeeper == nil {
+		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "circuit keeper is required for ante builder")
 	}
 
 	anteDecorators := []sdk.AnteDecorator{
 		ante.NewSetUpContextDecorator(), // outermost AnteDecorator. SetUpContext must be called first
 		wasmkeeper.NewLimitSimulationGasDecorator(options.NodeConfig.SimulationGasLimit), // after setup context to enforce limits early
 		wasmkeeper.NewCountTXDecorator(options.TXCounterStoreService),
+		circuitante.NewCircuitBreakerDecorator(options.CircuitKeeper),
 		ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker),
 		// this changes the minGasFees,
 		// and must occur before gas fee checks
@@ -78,15 +79,18 @@ func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {
 			}
 			return bondDenom
 		}),
-		feeabsante.NewFeeAbstrationMempoolFeeDecorator(*options.FeeAbsKeeper),
 
 		// validation checks
 		ante.NewValidateBasicDecorator(),
 		ante.NewTxTimeoutHeightDecorator(),
 		ante.NewValidateMemoDecorator(options.AccountKeeper),
 		ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
-		// fee abstraction fee deduction replaces sdk fee deduction
-		feeabsante.NewFeeAbstractionDeductFeeDecorate(options.AccountKeeper, options.BankKeeper, *options.FeeAbsKeeper, options.FeegrantKeeper),
+		ante.NewDeductFeeDecorator(
+			options.AccountKeeper,
+			options.BankKeeper,
+			options.FeegrantKeeper,
+			options.TxFeeChecker,
+		),
 		ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators
 		ante.NewValidateSigCountDecorator(options.AccountKeeper),
 		ante.NewSigGasConsumeDecorator(options.AccountKeeper, options.SigGasConsumer),