Some packages are missing (not listed anymore)

[drogga]

@butzist apps without app_name (label/title) are missing and not listed anymore, compared to older versions (like 1.10.0), upon launch it shows that the same amount of apps are still being loaded (303), but those 4 are simply missing from the list, check the screenshot:

[Kapcode]

resolve function

    for (int i = 0; i < all_packages.size(); ++i) {
        PackageInfo pack = all_packages.get(i);
        MyPackageInfo mypack;

            mypack = cache.getPackageInfo(pack.packageName, locale);
            if(mypack==null){
                failedPackagesList.add(pack.packageName);
            }else{
                if (mypack.getActivitiesCount() > 0) {
                    packages.add(mypack);
                }
            }

    }

PackageManagerCache.java

        PackageInfo info = null;
        try {
            info = pm.getPackageInfo(packageName, PackageManager.GET_ACTIVITIES);
        } catch (NameNotFoundException | RuntimeException reignored) {

        }

        try {
            myInfo = MyPackageInfo.fromPackageInfo(this, info, config);
        } catch (NameNotFoundException | RuntimeException reignored) {

        }

when populating UI pull from failed list to get the packages that info was not gathered from. That is a temp fix that works for my case on a parental control app work in progress.

https://github.com/Kapcode/HowToLaunchActivity

[Kapcode]

Issue is packageManager is getting all the packages, but pm.getPackageInfo(packageName, PackageManager.GET_ACTIVITIES);
endsup with Runtime exceptions

[drogga]

Thank You. Feel free to create a PR with the fix (a temp one or not, as long as it works it doesn't matter much) ;).

[Kapcode]

Just need access :) have a pull ready

[drogga]

Access?

[Kapcode]

Im getting a 403 error every time I try to make a pull request, which means I don't have access to make one

…

On Thu, Nov 30, 2023, 4:27 AM drogga ***@***.***> wrote: Access? — Reply to this email directly, view it on GitHub <#141 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPGVZPRET4TADZDTPMIHJLYHBGQ3AVCNFSM5PHJA5WKU5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TONZRGUZDCOI> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[drogga]

That's strange, because they shouldn't be restricted and anyone should be able to contribute, could it be GH or browser related issue ?

[drogga]

@butzist Can you pls. take a look (just in case) ?

[Kapcode]

Can't create a new pull request: Push failed: remote: No anonymous write access. Authentication failed for 'https://github.com/butzist/ActivityLauncher/

Error 403: Not Authorized
This request is only valid within same origin

Try to sign in as another user?

if any of that helps that's what I get when I try. If you try to create a new pull request through browser the "create pull request" button is disabled. Edge and chrome.

[butzist]

What you are trying to do, is pushing to our repo. That is not possible. Instead you need to fork the repo and push to your fork, and then create a PR from there.

[Kapcode]

Thanks for clarifying that, didn't know how that worked :)

…

On Thu, Nov 30, 2023, 3:18 PM Adam M. Szalkowski ***@***.***> wrote: What you are trying to do, is pushing to our repo. That is not possible. Instead you need to fork the repo and push to your fork, and then create a PR from there. — Reply to this email directly, view it on GitHub <#141 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPGVZITGUSHLLVY46US7WDYHDS2PAVCNFSM5PHJA5WKU5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TONZSGIYDCNA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[prospertxbox]

Having trouble figuring it out, not very experienced with git, all self taught, sorry for my ignorance, but this is what I have so far.

27bdea1

if you want to throw that in a commit, or do what you want with it, idc, but it makes everything show up.

[drogga]

Thanks.
I guess this is your other account...
This can't be merged, but the changes can be made manually. I hope @butzist will take a look and apply if there are no problems ASAP ;)

[drogga]

@butzist If you have time pls...

[butzist]

Included in https://github.com/butzist/ActivityLauncher/releases/tag/1.14.9
Thank you and let me know if it fixes the issue

[butzist]

Also released to Beta channel on Play Store. Usually takes ~1 day to approve. Feel free to download the apk from the github build/release instead.

[drogga]

They seem to be listed now, although I'm not sure why aren't they alphabetically (you can see on the screenshot), they are at some point, then they aren't at bottom after "Z".
Also:
It's still doesn't auto rotate based on the sensor orientation, when I force it to, it refreshes and jumps to the top of the list (I could fix this in the past with configChanges, but this method doesn't work anymore).
Has name/label in the manifest, it should just rely on the strings app_name for that (it's a mess).
extractNativeLibs="true" > doesn't have any, so it doesn't need this.
hasFragileUserData="true" > unnecessary, given that it doesn't store anything.
de.szalkowski.activitylauncher.SettingsActivity > exported="false" > should be "true"

I can edit directly most of them, except the name/label related ones (nor fix the sorting), because when I tried locally on the compiled build, the app name became a package/activity name, so I prefer to not touch the source because I'm not experienced and IDK if and how this might affect and if there will be any consequences, if I was editing the source with Android Studio for example, it will probably warn me about any errors/mistakes, but since I have a 15+ year old PCs - that's not an option.

@butzist you might want to address those yourself (trust me) ;)

[butzist]

Please keep the issues separate - this one is only about missing entries

[drogga]

Yeah, but the sorting is pretty much related...
Also, this is not an issue ticket, but a discussion, hence we can discuss multiple things in them (which I think is the whole idea/point of those and the use case), it's also Closed, so it doesn't matter that much.

@butzist
Would you like me to address some of those ?

[drogga]

...I guess not.