Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Ripples code #347

Open
dlevenstein opened this issue Oct 28, 2019 · 2 comments
Open

Join Ripples code #347

dlevenstein opened this issue Oct 28, 2019 · 2 comments
Assignees

Comments

@dlevenstein
Copy link
Collaborator

Make sure ripples code have same output.

Possibly: re-referencing to noise channel

add Elie

@AntonioFR8
Copy link
Collaborator

For now we will keep bz_FindRipples and detetec_swr as separated functions but will change the later so the inputs/outpus are the same. Plus add some new functionalities to both functions

@dlevenstein
Copy link
Collaborator Author

Sounds good to me.

@eliezyer also wanted to be involved in this and a few other issues, but I'm having trouble assigning him so I'll just tag him here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants