Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bz_PlotEphys worse than bz_MultiLFPPlot #395

Open
brendonw1 opened this issue Aug 17, 2020 · 5 comments
Open

bz_PlotEphys worse than bz_MultiLFPPlot #395

brendonw1 opened this issue Aug 17, 2020 · 5 comments

Comments

@brendonw1
Copy link
Collaborator

Correct? It seems bz_MultiLFPPlot is much better than bz_plotephys. But to a novice user bz_plotephys.m is the file you'd assume to use. It took me a while to realize there was an alternative and I even started re-doing some code before finding it was already done in bz_MultiLFPPlot.m

I propose we essentially depricate bz_PlotEphys.m by replacing the code in there with a commented referral to bz_MultiLFPPlot.m. Agree?

Later I'd propose we might change the working function to bz_PlotEphys.m (again because better name) and have bz_MultiLFPPlot.m have a commented point to that one... later on.

Thanks

@dlevenstein
Copy link
Collaborator

Not sure where PlotEphys came from. Would love to have contributions to bz_MultiLFPPlot.

@brendonw1
Copy link
Collaborator Author

Plot ephys looks about the same - likely an earlier version of multilfpplot tbh.
Maybe then non-controversial to add "For LFP and/or Spike plotting, please use bz_MultiLFPPlot.m" for now at least.
I'll do that unless I get pushback

@dlevenstein
Copy link
Collaborator

ah - fine by me

@brendonw1
Copy link
Collaborator Author

It appears that bz_PlotEphys is written by a DLevenstein in 2017... by way :)

@dlevenstein
Copy link
Collaborator

😂😂😂 what a goober.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants