Skip to content

Commit

Permalink
Remove warning about stubbed imports (#188)
Browse files Browse the repository at this point in the history
The warning added in #185 turns out to be too noisy: there are too many situations in which an import exists, but should be stubbed. In particular once StarlingMonkey is updated to include bytecodealliance/StarlingMonkey#218, the warning would essentially be shown for every component, because in most cases, the target world won't contain the necessary interfaces, by design.
  • Loading branch information
tschneidereit authored Feb 21, 2025
1 parent d547574 commit 3081f96
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/spidermonkey-embedding-splicer/src/stub_wasi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ where
let mut builder = FunctionBuilder::new(params.as_slice(), results.as_slice());
let _args = stub(&mut builder)?;

println!("Warning: the component import '{full_import}#{name}' isn't listed in the target WIT world, and will abort execution when called.");
builder.replace_import_in_module(module, iid);

return Ok(Some(fid));
Expand Down

0 comments on commit 3081f96

Please sign in to comment.