fixup workflow

bytecodealliance · Feb 22, 2025 · 6242b82 · 6242b82
1 parent b83b3a9
commit 6242b82
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -209,7 +209,6 @@ jobs:
         if: steps.starlingmonkey-aot.outputs.cache-hit != 'true'
         run: |
           npm run clean
-          npm run build:debug
           npm run build:weval
 
       - uses: actions/upload-artifact@v4
@@ -219,7 +218,6 @@ jobs:
           if-no-files-found: 'error'
           path: |
             lib/starlingmonkey_embedding_weval.wasm
-            lib/starlingmonkey_embedding.debug.wasm
             lib/starlingmonkey_ics.wevalcache
             build-release-weval
 
@@ -331,7 +329,6 @@ jobs:
           key: starlingmonkey-aot-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
           path: |
             lib/starlingmonkey_embedding_weval.wasm
-            lib/starlingmonkey_embedding.debug.wasm
             lib/starlingmonkey_ics.wevalcache
             build-release-weval
 
@@ -341,7 +338,6 @@ jobs:
           name: starlingmonkey-aot-node-${{matrix.node-version}}-${{ steps.starlingmonkey-commit.outputs.STARLINGMONKEY_HASH }}
           path: |
             lib/starlingmonkey_embedding_weval.wasm
-            lib/starlingmonkey_embedding.debug.wasm
             lib/starlingmonkey_ics.wevalcache
             build-release-weval
 

diff --git a/package.json b/package.json
@@ -22,13 +22,13 @@
   "scripts": {
     "clean": "npm run clean:starlingmonkey",
     "clean:starlingmonkey": "rm -rf build-release",
-    "build": "make release && make release-weval && make debug",
+    "build": "npm run build:release && npm run build:debug && npm run build:weval",
     "build:release": "make release",
     "build:weval": "make release-weval",
     "build:debug": "make debug",
     "test": "mocha -u tdd test/test.js --timeout 120000",
     "test:weval": "WEVAL_TEST=1 mocha -u tdd test/test.js --timeout 120000",
-    "prepublishOnly": "npm run build && npm run build:weval"
+    "prepublishOnly": "npm run build"
   },
   "files": [
     "lib/interfaces",

diff --git a/test/test.js b/test/test.js
@@ -40,8 +40,8 @@ suite('Builtins', () => {
       `,
         {
           sourceName: `${name}.js`,
-          // also test the debug build while we are about it
-          debugBuild: true,
+          // also test the debug build while we are about it (unless testing Weval)
+          debugBuild: !enableAot,
           enableFeatures,
           disableFeatures: maybeLogging(disableFeatures),
           enableAot