Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump StarlingMonkey to include wasi 0.2.3 #180

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

karthik2804
Copy link
Contributor

Updates StarlingMonkey dependency to 5ed4e1faf4b2a6cd3e2cbde154eb064e77c1c991.

@guybedford
Copy link
Collaborator

Thanks for sharing! We also need to run the update-wasi.sh script in the root of the repo to complete updating ComponentizeJS to this version.

@karthik2804
Copy link
Contributor Author

It seems to add wasmtime as a dependency is that to be expected and should it be committed/ added as submodule? Thanks!

@guybedford
Copy link
Collaborator

Yes, it clones the submodule to copy the files, but don't check it in.

@guybedford
Copy link
Collaborator

test/wit/test1.wit also needs to be updated per the CI error. Just let me know if you need further help.

@karthik2804 karthik2804 force-pushed the starlinmonkey_0_2_3 branch 2 times, most recently from 7cddabf to 164e227 Compare January 21, 2025 22:53
@guybedford guybedford merged commit 6c06480 into bytecodealliance:main Jan 22, 2025
11 checks passed
@karthik2804 karthik2804 deleted the starlinmonkey_0_2_3 branch January 22, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants