Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the examples directory in EXAMPLE.md and .gitignore #195

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

tanishiking
Copy link
Contributor

Also, removed the hello.component.wasm from git since it is now ignored.

Also, removed the hello.component.wasm from git since it is now ignored.
@guybedford
Copy link
Collaborator

Wow, seems this has exposed a bug in the example test infrastructure, thanks for posting!

@tanishiking
Copy link
Contributor Author

tanishiking commented Feb 26, 2025

Oops, removing the wasm binary from git expose the bug in the script, this should fix the test b6cdaf8 nope needs to cd .. after build.

edit: okay now it's ready to go

@guybedford
Copy link
Collaborator

Nice thank you for figuring this one out.

@guybedford guybedford merged commit 15df525 into bytecodealliance:main Feb 26, 2025
9 checks passed
@tanishiking tanishiking deleted the fix-typo branch February 27, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants