refactor(agent-snapshot): improve architecture and api design #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private ensureSnapshotDirectory(): void { | ||
| if (!fs.existsSync(this.snapshotPath)) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
|
|
||
| private ensureSnapshotDirectory(): void { | ||
| if (!fs.existsSync(this.snapshotPath)) { | ||
| fs.mkdirSync(this.snapshotPath, { recursive: true }); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
4 tasks
- Simplify AgentSnapshot class by removing prototype manipulation - Rename test() method from replay() for clearer semantics - Add comprehensive README with examples and best practices - Improve type safety and error handling - Streamline AgentSnapshotRunner CLI interface
ulivz
force-pushed
the
refactor/agent-snapshot-only
branch
from
c0c6e16 to
d314b1b
Compare
|
Closing this since the regression cost introduced by this reconstruction is too high |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
@tarko/agent-snapshotpackage to improve architecture, API design, and maintainability while maintaining backward compatibility.Key Improvements
🏗️ Architecture Simplification
AgentSnapshotclass🎯 API Design Enhancement
replay()totest()for clearer semantics (with backward compatibility)generate()for snapshot creation,test()for verification🔒 Type Safety Improvements
📚 Documentation Overhaul
🧹 Code Quality
AgentSnapshotRunnerCLI interfaceBefore/After Comparison
Before:
After:
Backward Compatibility
replay()method preserved as deprecated alias fortest()Technical Details
snapshot-diffdependencyChecklist