diff --git a/bolt/dwio/common/tests/utils/DataSetBuilder.h b/bolt/dwio/common/tests/utils/DataSetBuilder.h index cb74f2f08..62e7e78cb 100644 --- a/bolt/dwio/common/tests/utils/DataSetBuilder.h +++ b/bolt/dwio/common/tests/utils/DataSetBuilder.h @@ -111,7 +111,7 @@ class DataSetBuilder { if (counter % 100 < repeats) { numbers->set(row, T(counter % repeats)); } else if (counter % 100 > 90 && row > 0) { - numbers->copy(numbers, row - 1, row, 1); + numbers->copy(numbers, row, row - 1, 1); } else { int64_t value; if (rareFrequency && counter % rareFrequency == 0) { diff --git a/bolt/dwio/parquet/tests/reader/E2EFilterTest.cpp b/bolt/dwio/parquet/tests/reader/E2EFilterTest.cpp index a09d21cc7..c62b49b06 100644 --- a/bolt/dwio/parquet/tests/reader/E2EFilterTest.cpp +++ b/bolt/dwio/parquet/tests/reader/E2EFilterTest.cpp @@ -344,9 +344,11 @@ TEST_F(E2EFilterTest, floatAndDouble) { } TEST_F(E2EFilterTest, shortDecimalDictionary) { + // decimal(8, 5) maps to 4 bytes FLBA in Parquet. // decimal(10, 5) maps to 5 bytes FLBA in Parquet. // decimal(17, 5) maps to 8 bytes FLBA in Parquet. for (const auto& type : { + "shortdecimal_val:decimal(8, 5)", "shortdecimal_val:decimal(10, 5)", "shortdecimal_val:decimal(17, 5)", }) { @@ -373,9 +375,11 @@ TEST_F(E2EFilterTest, shortDecimalDirect) { options_.enableDictionary = false; options_.dataPageSize = 4 * 1024; + // decimal(8, 5) maps to 4 bytes FLBA in Parquet. // decimal(10, 5) maps to 5 bytes FLBA in Parquet. // decimal(17, 5) maps to 8 bytes FLBA in Parquet. for (const auto& type : { + "shortdecimal_val:decimal(8, 5)", "shortdecimal_val:decimal(10, 5)", "shortdecimal_val:decimal(17, 5)", }) {