fix(frontend): add engines field to package.json for Node.js and pnpm version requirements#2751
Open
unn-Known1 wants to merge 1 commit intobytedance:mainfrom
Open
fix(frontend): add engines field to package.json for Node.js and pnpm version requirements#2751unn-Known1 wants to merge 1 commit intobytedance:mainfrom
unn-Known1 wants to merge 1 commit intobytedance:mainfrom
Conversation
… version requirements Addresses issue bytedance#76 by adding explicit engine requirements: - Node.js >=20 (required for modern Next.js features) - pnpm >=10 (required as specified in packageManager) This prevents installation issues with older versions that may cause unexpected problems like lock-file version mismatches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
enginesfield tofrontend/package.jsonto specify minimum version requirements for Node.js and pnpm, addressing issue #76.Problem
Without explicit engine requirements, developers might use incompatible Node.js or pnpm versions, leading to:
Solution
Added the following to
package.json:These versions align with:
packageManagerfield which specifiespnpm@10.26.2Testing
jq)pnpm install --frozen-lockfilesucceedspnpm formatcheck passespackage.jsonmodified)Note
This contribution was developed with AI assistance.