- Didn't do lab in order and so did all SV before simulated anything. Gave problems with top
- Didn't understand simulation was hex
- Wrong part name due to video
- Forgot to change file types to SystemVerilog
- Implement circuits they are given verbatim (sim lab)
- Need to follow syntax in the book rather than thinking C syntax wll work
- Taking off for ports being in a different order than specified seems extreme to me
- Otherwise, we want to be tough on the coding standard, including indentation, comments, etc.
-
Counter outputs cannot be in an always_ff block. Why?
-
Stop trying to use your mod_counter for everything already...
-
Any assignment inside an always_ff will generate flip flops. If that is not what you intended, don't put the assignment there.
-
CL doesn't contain flip flops. Sequential logic does. Learn the difference.
-
"cnt = cnt + 1" in an always_comb block is ALWAYS wrong. All a FSM's always_comb can do is produce outputs in response to inputs.
-
[3:0] is not a type. This is wrong: output logic done, [3:0] q
This is right: output logic done, logic[3:0] q
This is even better: output logic done, output logic[3:0] q
-
Indentation is not optional.
-
Follow the code samples in the book