You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw #52 but that appears to not address camel-cased properties. I'm working with a-ocean and found that amplitudeVariance did not appear to change visibly, when I updated it:
For this primitive, the ocean should be completely still if amplitude = amplitudeVariance = speed = speedVariance = 0. Here's a simple example where all are zero and yet, the ocean still moves: http://jsfiddle.net/wz02xybp/1/. I tried hyphenated and all-lowercase versions of the property name as well (in case I just misunderstood)
I copied and pasted the a-ocean source in and found that data.amplitudeVariance wasn't being updated. http://jsfiddle.net/wz02xybp/2/ (I console.log(data.amplitudeVariance...)
Does this look about right? Or have I simply misinterpreted an AFRAME mapping convention (e.g., amplitudeVariance actually means to use variance-amplitude)? Happy to make a PR if appropriate.
The text was updated successfully, but these errors were encountered:
vincentfretin
changed the title
Some primitive property mappings fail (camel cased v. hypenated properties)
[ocean] Some primitive property mappings fail (camel cased v. hypenated properties)
Dec 7, 2022
I saw #52 but that appears to not address camel-cased properties. I'm working with
a-ocean
and found thatamplitudeVariance
did not appear to change visibly, when I updated it:amplitude = amplitudeVariance = speed = speedVariance = 0
. Here's a simple example where all are zero and yet, the ocean still moves: http://jsfiddle.net/wz02xybp/1/. I tried hyphenated and all-lowercase versions of the property name as well (in case I just misunderstood)a-ocean
source in and found thatdata.amplitudeVariance
wasn't being updated. http://jsfiddle.net/wz02xybp/2/ (Iconsole.log(data.amplitudeVariance...)
amplitudevariance
(all lowercase, http://jsfiddle.net/wz02xybp/3/) oramplitude-variance
(hypenated, http://jsfiddle.net/wz02xybp/4/), all is well.Does this look about right? Or have I simply misinterpreted an AFRAME mapping convention (e.g.,
amplitudeVariance
actually means to usevariance-amplitude
)? Happy to make a PR if appropriate.The text was updated successfully, but these errors were encountered: