Skip to content

Commit d13122c

Browse files
committed
Merge tag 'kvm-riscv-fixes-5.19-2' of https://github.com/kvm-riscv/linux into HEAD
KVM/riscv fixes for 5.19, take #2 - Fix missing PAGE_PFN_MASK - Fix SRCU deadlock caused by kvm_riscv_check_vcpu_requests()
2 parents 4a57a84 + be82abe commit d13122c

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

arch/riscv/include/asm/pgtable-64.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ static inline pud_t pfn_pud(unsigned long pfn, pgprot_t prot)
175175

176176
static inline unsigned long _pud_pfn(pud_t pud)
177177
{
178-
return pud_val(pud) >> _PAGE_PFN_SHIFT;
178+
return __page_val_to_pfn(pud_val(pud));
179179
}
180180

181181
static inline pmd_t *pud_pgtable(pud_t pud)
@@ -278,21 +278,21 @@ static inline p4d_t pfn_p4d(unsigned long pfn, pgprot_t prot)
278278

279279
static inline unsigned long _p4d_pfn(p4d_t p4d)
280280
{
281-
return p4d_val(p4d) >> _PAGE_PFN_SHIFT;
281+
return __page_val_to_pfn(p4d_val(p4d));
282282
}
283283

284284
static inline pud_t *p4d_pgtable(p4d_t p4d)
285285
{
286286
if (pgtable_l4_enabled)
287-
return (pud_t *)pfn_to_virt(p4d_val(p4d) >> _PAGE_PFN_SHIFT);
287+
return (pud_t *)pfn_to_virt(__page_val_to_pfn(p4d_val(p4d)));
288288

289289
return (pud_t *)pud_pgtable((pud_t) { p4d_val(p4d) });
290290
}
291291
#define p4d_page_vaddr(p4d) ((unsigned long)p4d_pgtable(p4d))
292292

293293
static inline struct page *p4d_page(p4d_t p4d)
294294
{
295-
return pfn_to_page(p4d_val(p4d) >> _PAGE_PFN_SHIFT);
295+
return pfn_to_page(__page_val_to_pfn(p4d_val(p4d)));
296296
}
297297

298298
#define pud_index(addr) (((addr) >> PUD_SHIFT) & (PTRS_PER_PUD - 1))
@@ -347,15 +347,15 @@ static inline void pgd_clear(pgd_t *pgd)
347347
static inline p4d_t *pgd_pgtable(pgd_t pgd)
348348
{
349349
if (pgtable_l5_enabled)
350-
return (p4d_t *)pfn_to_virt(pgd_val(pgd) >> _PAGE_PFN_SHIFT);
350+
return (p4d_t *)pfn_to_virt(__page_val_to_pfn(pgd_val(pgd)));
351351

352352
return (p4d_t *)p4d_pgtable((p4d_t) { pgd_val(pgd) });
353353
}
354354
#define pgd_page_vaddr(pgd) ((unsigned long)pgd_pgtable(pgd))
355355

356356
static inline struct page *pgd_page(pgd_t pgd)
357357
{
358-
return pfn_to_page(pgd_val(pgd) >> _PAGE_PFN_SHIFT);
358+
return pfn_to_page(__page_val_to_pfn(pgd_val(pgd)));
359359
}
360360
#define pgd_page(pgd) pgd_page(pgd)
361361

arch/riscv/include/asm/pgtable.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ static inline pgd_t pfn_pgd(unsigned long pfn, pgprot_t prot)
261261

262262
static inline unsigned long _pgd_pfn(pgd_t pgd)
263263
{
264-
return pgd_val(pgd) >> _PAGE_PFN_SHIFT;
264+
return __page_val_to_pfn(pgd_val(pgd));
265265
}
266266

267267
static inline struct page *pmd_page(pmd_t pmd)
@@ -590,14 +590,14 @@ static inline pmd_t pmd_mkinvalid(pmd_t pmd)
590590
return __pmd(pmd_val(pmd) & ~(_PAGE_PRESENT|_PAGE_PROT_NONE));
591591
}
592592

593-
#define __pmd_to_phys(pmd) (pmd_val(pmd) >> _PAGE_PFN_SHIFT << PAGE_SHIFT)
593+
#define __pmd_to_phys(pmd) (__page_val_to_pfn(pmd_val(pmd)) << PAGE_SHIFT)
594594

595595
static inline unsigned long pmd_pfn(pmd_t pmd)
596596
{
597597
return ((__pmd_to_phys(pmd) & PMD_MASK) >> PAGE_SHIFT);
598598
}
599599

600-
#define __pud_to_phys(pud) (pud_val(pud) >> _PAGE_PFN_SHIFT << PAGE_SHIFT)
600+
#define __pud_to_phys(pud) (__page_val_to_pfn(pud_val(pud)) << PAGE_SHIFT)
601601

602602
static inline unsigned long pud_pfn(pud_t pud)
603603
{

arch/riscv/kvm/mmu.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static inline unsigned long gstage_pte_index(gpa_t addr, u32 level)
5454

5555
static inline unsigned long gstage_pte_page_vaddr(pte_t pte)
5656
{
57-
return (unsigned long)pfn_to_virt(pte_val(pte) >> _PAGE_PFN_SHIFT);
57+
return (unsigned long)pfn_to_virt(__page_val_to_pfn(pte_val(pte)));
5858
}
5959

6060
static int gstage_page_size_to_level(unsigned long page_size, u32 *out_level)

arch/riscv/kvm/vcpu.c

+2
Original file line numberDiff line numberDiff line change
@@ -781,9 +781,11 @@ static void kvm_riscv_check_vcpu_requests(struct kvm_vcpu *vcpu)
781781

782782
if (kvm_request_pending(vcpu)) {
783783
if (kvm_check_request(KVM_REQ_SLEEP, vcpu)) {
784+
kvm_vcpu_srcu_read_unlock(vcpu);
784785
rcuwait_wait_event(wait,
785786
(!vcpu->arch.power_off) && (!vcpu->arch.pause),
786787
TASK_INTERRUPTIBLE);
788+
kvm_vcpu_srcu_read_lock(vcpu);
787789

788790
if (vcpu->arch.power_off || vcpu->arch.pause) {
789791
/*

0 commit comments

Comments
 (0)