Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST JSON: Constants are not present #1540

Open
Caleb-o opened this issue Oct 10, 2024 · 4 comments
Open

AST JSON: Constants are not present #1540

Caleb-o opened this issue Oct 10, 2024 · 4 comments

Comments

@Caleb-o
Copy link
Contributor

Caleb-o commented Oct 10, 2024

Constants seem to not be emitted into the JSON at all, when they should be.

@cardisk
Copy link
Contributor

cardisk commented Oct 11, 2024

Hi, new here. I was trying to solve this issue and I also added the type to the globals as well. I will try to add also the init value. Is it ok if I collapse the two issues in only one?
By the way this is my first contribution ever, there are any instructions on how to contribute to this project beside the code of conduct and the codestyle files?

@lerno
Copy link
Collaborator

lerno commented Oct 12, 2024

Not really, just rebase the commit so that it's a single commit. And add a line in the release notes for the change.

cardisk added a commit to cardisk/c3c that referenced this issue Oct 22, 2024
…ang#1541

Fixing uint64_t printf format and binary else operator
@lerno
Copy link
Collaborator

lerno commented Nov 14, 2024

Is this fixed?

@cardisk
Copy link
Contributor

cardisk commented Nov 14, 2024

Yes. There are a few expressions that I really cannot trigger so I wasn't able to output a specific value for them, instead I outputted a TODO: with the corresponding type so in the future it can be easy to implement them. At the moment there are no TODOs inside the standard library.
If this issue can be closed I think also the #1541 one should, because inside the AST constants and globals have the same output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants