Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reviews page #79

Open
AliAsjad512 opened this issue Oct 17, 2023 · 25 comments
Open

Adding reviews page #79

AliAsjad512 opened this issue Oct 17, 2023 · 25 comments
Assignees
@vedantheda @AliAsjad512
Labels
hacktoberfest It is for hacktoberfest hacktoberfest-accepted Try-Out Features to be tried to

Comments

@AliAsjad512
Copy link

AliAsjad512 commented Oct 17, 2023 •
edited
Loading

Hello PA, I am gonna add the review page for this site. I think that will look more impressive for website
@c4coderandcreator
Copy link
Owner

Hey Ali what does PA mean here !! before you start contributing , I request you to give a go to contributing guidelines https://github.com/c4coderandcreator/Flavour-Fusion/blob/main/CONTRIBUTING.md

Then contribute !! Also ss and demo of changes are welcome !!

@c4coderandcreator c4coderandcreator added hacktoberfest It is for hacktoberfest hacktoberfest-accepted Try-Out Features to be tried to labels Oct 17, 2023
@c4coderandcreator
Copy link
Owner

Hey @AliAsjad512 Any Update ?

@AliAsjad512
Copy link
Author

Hey @AliAsjad512 Any Update?

I am really sorry. This first time I am contributing and not know whether you accept my request or not. Just receive your notifications all in one and gonna start work on it .I will keep you updated

@c4coderandcreator
Copy link
Owner

no one is working on this because it is assigned to you !! complete it as soon as possible or let me know if any issue is there

@AliAsjad512
Copy link
Author

AliAsjad512 commented Oct 19, 2023 via email

@AliAsjad512
Copy link
Author

Most of the part done. Will be uploaded soom

@c4coderandcreator
Copy link
Owner

ok @AliAsjad512 Take your time !!

@vedantheda
Copy link
Contributor

vedantheda commented Oct 23, 2023 •
edited
Loading

Hey, can you assign this to me?

I'll add a testimonials section with a carousel on the home page

@c4coderandcreator
Copy link
Owner

@vedantheda while creating PR , share the ss of the features you have added !!

@AliAsjad512
Copy link
Author

Hey, can you assign this to me?

I'll add a testimonials section with a carousel on the home page

I have done so for and gonna push my code soon.

@AliAsjad512
Copy link
Author

Hi brother!. Can you tell me how I have to push my code ??

@AliAsjad512
Copy link
Author

I have done my code

@AliAsjad512
Copy link
Author

can you tell me how can I push my code??

@c4coderandcreator
Copy link
Owner

create PR with UI-Improvement branch @AliAsjad512

@vedantheda
Copy link
Contributor

Is this issue marked as resolved? or is it on going?

@c4coderandcreator
Copy link
Owner

This is in progress @vedantheda

@AliAsjad512
Copy link
Author

resoved

@AliAsjad512
Copy link
Author

I have pushed my code. Can you check plz and tell if it need modification??

@c4coderandcreator
Copy link
Owner

you pushed your code ?? You should create a PR now !!

@AliAsjad512
Copy link
Author

I create a branch like UI-new and push my code there because the branch you mentioned was showing on my side

@c4coderandcreator
Copy link
Owner

Hey you need to watch some videos on working on a open source project !! just look around YT

@AliAsjad512
Copy link
Author

ok

@AliAsjad512
Copy link
Author

I got to mess up with my code. Is that ok I can submit my code after a while

1 similar comment
@AliAsjad512
Copy link
Author

I got to mess up with my code. Is that ok I can submit my code after a while

@c4coderandcreator
Copy link
Owner

I got to mess up with my code. Is that ok I can submit my code after a while

take your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vedantheda vedantheda

@AliAsjad512 AliAsjad512

Labels
hacktoberfest It is for hacktoberfest hacktoberfest-accepted Try-Out Features to be tried to
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@c4coderandcreator @vedantheda @AliAsjad512