-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for leading spaces in search pattern #199
Comments
I think this makes sense. Where did you find out about |
We should document this in the README too. What keywords do we use for space and tab? Simply |
I agree documenting this would be a good idea. I believe there were some other things I didn't find in the README but I didn't think to write them down. I'll create another ticket if it comes to mind. I like |
I was trying to achieve the same thing. I'm using bumpversion to bump the version in a package(-lock).json and both the search and replace patterns need to be prefixed by two spaces (and include newlines). Limited (and undocumented) special character handling was added in PR #135, it would be nice if this was expanded to include whitespace characters. |
I think just like #221 this would most conveniently be fixed by allowing configuration in a |
TOML support is discussed in #42. But I think this approach is simpler, and thus could end up being release sooner too. |
This issue has been solved by |
Leading spaces are currently trimmed from the search pattern. I believe this is inherent in the library used to parse the config file. Since this effectively makes bumpversion unusable for any projects that need a search pattern with leading spaces, I think it would be valuable to add space (and potentially tab) to the special character context so it can be used similarly to
{#}
.The text was updated successfully, but these errors were encountered: