Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on study view clinical data tab's download is broken #11142

Open
inodb opened this issue Oct 30, 2024 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#5058
Open

on study view clinical data tab's download is broken #11142

inodb opened this issue Oct 30, 2024 · 3 comments · May be fixed by cBioPortal/cbioportal-frontend#5058
Labels
bug good first issue

Comments

@inodb
Copy link
Member

inodb commented Oct 30, 2024 •
edited
Loading

The download button here:

image

Gives JSON output rather than a TSV:

image

Interestingly it does work when you click on this button:

image

Shouldn't these have the same behavior?
@Amrithesh-Kakkoth
Copy link

Amrithesh-Kakkoth commented Oct 31, 2024 •
edited
Loading

where did you find the upper image download button?

@Srayash
Copy link

Srayash commented Nov 6, 2024 •
edited
Loading

hey @inodb this issue occurs as the serializeTableData uses , instead of \t as a delimiter.
https://github.com/cBioPortal/cbioportal-frontend/blob/master/src/shared/components/tableHeaderControls/TableHeaderControls.tsx
Screenshot 2024-11-07 at 12 13 55 AM

can I work on this if this is open?

@arishta-dev
Copy link

hi @inodb
I have put a fix for the issue - please review cBioPortal/cbioportal-frontend#5058
Thanks!

@arishta-dev arishta-dev linked a pull request Nov 28, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11142 Fix download button in clinical tab arishta-dev/cbioportal-frontend
4 participants
@inodb @Srayash @Amrithesh-Kakkoth @arishta-dev