-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gene column in the Mutations table #5049
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@arishta-dev Thanks so much for working on this! Could you change the logic to only add the column when downloading the file rather than always showing it? Ideally we wouldn't see it in the UI. The user already knows they're looking at CDKN2A in the browser, but we want to make sure it's clear in the downloaded file too |
6ca65cf
to
05fc6e3
Compare
hi @inodb Thanks for your suggestion - I have modified the code, now gene column will only show in the tsv file. |
7494450
to
dc1480f
Compare
dc1480f
to
6629b06
Compare
6629b06
to
32a16fa
Compare
Fixes cBioPortal/cbioportal#10932
Summary:
Detailed summary of the change:
-> The
GeneColumnFormatter
was already implemented in the codebase, so simply addedMutationTableColumnType.GENE
to the default columns array inResultsViewMutationTable.tsx
. This makes the gene information visible in the mutation table. Also this column will only visible in the tsv file, not in the UI.Screenshot:
Here is a screenshot showing Before and After state of the mutation table.
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR