Improve dependency URL parsing with regex for flexible format support

- Refactor `getDependencyGitUrl` and `getDependencyName` to use regex for matching:
  - Supports `user/repo` shorthand format.
  - Handles full GitHub/GitLab URLs with optional `www` and `.git` suffixes.
  - Allows generic `.git` URLs, broadening compatibility.

Author: SunPodder

src/Cmd/Add.cc

@@ -10,6 +10,7 @@
 #include <fstream>
 #include <functional>
 #include <optional>
+#include <regex>
 #include <string>
 #include <string_view>
 #include <toml.hpp>
@@ -66,27 +67,51 @@ handleDependency(
 
 static std::string
 getDependencyGitUrl(const std::string_view dep) {
-  if (dep.find("://") == std::string_view::npos) {
-    // check if atleast in "user/repo" format
-    if (dep.find('/') == std::string_view::npos) {
-      logger::error("Invalid dependency: " + std::string(dep));
-      return "";
-    }
+  std::regex user_repo_regex(R"(^([^/]+)/([^/]+)$)");
+  std::regex url_regex(
+      R"((?:https?://)?(?:www\.)?(?:github|gitlab)\.com/([^/]+/[^/]+)(?:\.git)?)"
+  );
+  std::regex generic_git_regex(R"((?:https?://)?.+/(.+)\.git)");
 
-    return "https://github.com/" + std::string(dep) + ".git";
+  std::cmatch match;
+  if (std::regex_match(dep.begin(), dep.end(), match, user_repo_regex)) {
+    // Format is "user/repo"
+    return "https://github.com/" + match[1].str() + "/" + match[2].str()
+           + ".git";
+  } else if (std::regex_match(dep.begin(), dep.end(), match, url_regex)) {
+    // Format is a valid GitHub or GitLab URL
+    return match[0].str();
+  } else if (std::regex_match(
+                 dep.begin(), dep.end(), match, generic_git_regex
+             )) {
+    // Format is a generic git URL ending with .git
+    return match[0].str();
+  } else {
+    // Invalid input format
+    return "";
   }
-  return std::string(dep);
 }
 
 static std::string
 getDependencyName(const std::string_view dep) {
   std::string name;
-  if (dep.find("://") == std::string_view::npos) {
+  std::regex url_regex(
+      R"((?:https?://)?(?:www\.)?(?:github|gitlab)\.com/([^/]+)/([^/]+)(?:\.git)?)"
+  );
+  std::regex generic_git_regex(R"((?:https?://)?.+/(.+)\.git)");
+
+  std::cmatch match;
+  if (std::regex_match(dep.begin(), dep.end(), match, url_regex)) {
+    name = match[2].str(); // Extract only the repo name
+  } else if (std::regex_match(
+                 dep.begin(), dep.end(), match, generic_git_regex
+             )) {
+    name = match[1].str();
+  } else if (dep.find('/') != std::string_view::npos) {
+    // Assume format is User/Repo
     name = dep.substr(dep.find_last_of('/') + 1);
   } else {
-    name = dep.substr(
-        dep.find_last_of('/') + 1, dep.find(".git") - dep.find_last_of('/') - 1
-    );
+    return "";
   }
 
   // Remove trailing '.git' if it exists
@@ -139,6 +164,7 @@ addDependencyToManifest(
       const std::string depName = getDependencyName(dep);
 
       if (gitUrl.empty() || depName.empty()) {
+        logger::error("Invalid dependency: " + std::string(dep));
         return EXIT_FAILURE;
       }